Bug 2454354

Summary: Review Request: perl-Consumer-NonBlock - Send data between processes without blocking
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: jplesnik: fedora-review+
Hardware: All   
OS: Linux   
URL: https://metacpan.org/dist/Consumer-NonBlock
Whiteboard:
Fixed In Version: perl-Consumer-NonBlock-0.003-1.fc45 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-04-08 14:58:45 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2453268    

Description Petr Pisar 2026-04-02 14:16:43 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Consumer-NonBlock/perl-Consumer-NonBlock.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Consumer-NonBlock/perl-Consumer-NonBlock-0.002-1.fc45.src.rpm
Description:
It is very easy to end up in a situation where a producer process produces
data faster than a consumer process can read/process it resulting in the
producer blocking on a full pipe buffer. This module allows 2 processes to
share data similar to a pipe, but without the producer blocking due to full
pipe buffers.
Fedora Account System Username: ppisar

Comment 1 Fedora Review Service 2026-04-03 02:50:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10288800
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2454354-perl-consumer-nonblock/fedora-rawhide-x86_64/10288800-perl-Consumer-NonBlock/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Jitka Plesnikova 2026-04-08 13:45:31 UTC
Source file is ok
Summary is ok
License is ok
FIX: License is updated in new version 0.003 - please update package before
     releasing

Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Consumer-NonBlock-0.002-1.fc45.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Fcntl)
      1 perl(File::Path)
      1 perl(File::Spec)
      1 perl(File::Temp)
      1 perl(IO::Handle) >= 1.27
      1 perl-libs
      1 perl(Object::HashBase)
      1 perl(strict)
      1 perl(Time::HiRes)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Consumer-NonBlock-0.002-1.fc45.noarch.rpm | sort | uniq -c
      1 perl(Consumer::NonBlock) = 0.002
      1 perl-Consumer-NonBlock = 0.002-1.fc45
Binary provides are Ok.

$ rpmlint ./perl-Consumer-NonBlock*
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

perl-Consumer-NonBlock-tests.noarch: W: no-documentation
perl-Consumer-NonBlock.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Consumer-NonBlock/LICENSE
 3 packages and 1 specfiles checked; 1 errors, 1 warnings, 12 filtered, 1 badness; has taken 0.3 s
Rpmlint 
NOTE: incorrect-fsf-address would be fixed by new version 0.003

The package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' item.

Resolution:
Approved

Comment 3 Fedora Admin user for bugzilla script actions 2026-04-08 14:27:44 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Consumer-NonBlock

Comment 4 Petr Pisar 2026-04-08 14:37:50 UTC
Thank you for the review.