Bug 2455323

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10295078
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2455323-rust-pulp/fedora-rawhide-x86_64/10295078-rust-pulp/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

The built packages don't all install:

Problem: conflicting requests
  - nothing provides (crate(pulp-macro/default) >= 0.1.1 with crate(pulp-macro/default) < 0.2.0~) needed by rust-pulp+macro-devel-0.22.2-1.fc45.noarch from @commandline

Looks like you need to either package the "pulp-macro" crate or hide the "macro" feature.

(In reply to Fabio Valentini from comment #2)
> The built packages don't all install:
> 
> Problem: conflicting requests
>   - nothing provides (crate(pulp-macro/default) >= 0.1.1 with
> crate(pulp-macro/default) < 0.2.0~) needed by
> rust-pulp+macro-devel-0.22.2-1.fc45.noarch from @commandline
> 
> Looks like you need to either package the "pulp-macro" crate or hide the
> "macro" feature.

Thanks for pointing this out. It was difficult to spot when everything was green, and wiremix haven't requested it.

As for the solution, I went with hiding the "macro" feature. Please re-review.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10406644
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2455323-rust-pulp/fedora-rawhide-x86_64/10406644-rust-pulp/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Looks like the links are now returning HTTP 404 errors, please check.

They work for me and they worked for Copr as seen from the successful build above. 

Which links are you referring to?

It looks like this was an infrastructure issue that caused any fedorapeople links to be broken, but it was fixed.

Doing final review now ...

Looks good to me now.

===

Package was generated with rust2rpm, simplifying the review.
Patches are justified, documented, and are OK to keep downstream-only.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pulp
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Thank you for the review.

FEDORA-2026-0641fa2899 (rust-pulp-0.22.2-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-0641fa2899

FEDORA-2026-0641fa2899 (rust-pulp-0.22.2-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.