Bug 245649
| Summary: | Review Request: gnome-password-generator - Graphical secure password generator | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Debarshi Ray <debarshir> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-07-31 19:33:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Debarshi Ray
2007-06-25 21:06:21 UTC
SPEC: https://fedoraproject.org/wiki/DebarshiRay?action=AttachFile&do=get&target=gnome-password-generator-2.spec SRPM: https://fedoraproject.org/wiki/DebarshiRay?action=AttachFile&do=get&target=gnome-password-generator-1.4-2.fc8.src.rpm I have rectified some issues, but keep getting errors in mock. Looks like there are some problems with 'Requires/BuildRequires', but can not figure out what is wrong. (Only I tried to rebuild this package) (In reply to comment #1) > I have rectified some issues, but keep getting errors in mock. What problem are you seeing? I just tried to rebuild and it passed. Also rebuild by koji seems fine. http://koji.fedoraproject.org/koji/taskinfo?taskID=80593 Alright, maybe I was seeing things. :-) Those were early days for me with mock,
and maybe I made a stupid mistake.
One question: is it necessary to have...
make install prefix=%{_prefix} bindir=%{_bindir} datadir=%{_datadir}
DESTDIR=$RPM_BUILD_ROOT
...instead of...
make install DESTDIR=$RPM_BUILD_ROOT
...since the hard-coded defaults are good enough?
Spec: http://rishi.fedorapeople.org/gnome-password-generator.spec SRPM: http://rishi.fedorapeople.org/gnome-password-generator-1.4-3.fc8.src.rpm Here are the current spec and SRPM. Koji taskinfo: http://koji.fedoraproject.org/koji/taskinfo?taskID=80718 For 1.4-3:
* BuildRequires
- I just watched Makefile and I don't think this package
must have gnome-python2 pygtk2-devel as BuildRequires.
* Requires
- It may well that this package has "Requires: redhat-artwork".
--------------------------------------------------------
102 menu_items = (
103 ("/_File", None, None, 0, "<Branch>"),
104 ("/File/_Quit", "<control>Q", self.DestroyCallback, 0,
"<StockItem>", gtk.STOCK_QUIT),
105 ("/_Help", None, None, 0, "<Branch>"),
106 ("/_Help/_About", None, self.AboutCallback, 0,
"<StockItem>", "gnome-stock-about")
107 )
--------------------------------------------------------
* icon
- By the way, why do you have to install icon under
%{_datadir}/icons/hicolor/48x48/apps, even though it is
also installed under %{_datadir}/pixmaps/ ?
> * BuildRequires > - I just watched Makefile and I don't think this package > must have gnome-python2 pygtk2-devel as BuildRequires. Fixed. I wonder why the Dag Apt and FC6 package had them. > * Requires > - It may well that this package has "Requires: redhat-artwork". Fixed. > * icon > - By the way, why do you have to install icon under > %{_datadir}/icons/hicolor/48x48/apps, even though it is > also installed under %{_datadir}/pixmaps/ ? While creating the initial build, I was told on #fedora-devel that only icons placed under %{_datadir}/icons/hicolor are themeable, while stuff under %{_datadir}/pixmaps are non-themeable. I was advised to put the icons under %{_datadir}/icons/hicolor/48x48/apps. However the icon size is 96x96, and so I have now put it under %{_datadir}/icons/hicolor/96x96/apps. Spec: http://rishi.fedorapeople.org/gnome-password-generator-4.spec SRPM: http://rishi.fedorapeople.org/gnome-password-generator-1.4-4.fc8.src.rpm Koji info: http://koji.fedoraproject.org/koji/taskinfo?taskID=82600 Ah, I forgot to write (although I noticed: ) - Desktop file Category "Application" is deprecated and should be removed. Everything else is okay. ----------------------------------------------------------------- This package (gnome-password-generator) is APPROVED by me ----------------------------------------------------------------- Spec: http://rishi.fedorapeople.org/gnome-password-generator-5.spec SRPM: http://rishi.fedorapeople.org/gnome-password-generator-1.4-5.fc8.src.rpm Koji info: http://koji.fedoraproject.org/koji/taskinfo?taskID=83573 New Package CVS Request ======================= Package Name: gnome-password-generator Short Description: Graphical secure password generator. Owners: debarshi.ray Branches: FC-6, F-7 InitialCC: cvs done. Package Change Request ====================== Package Name: gnome-password-generator New Branches: F-8 cvs done. |