Bug 245655
Summary: | Review Request: perl-Gearman - Distributed job system | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ruben Kerkhof <ruben> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, ppisar |
Target Milestone: | --- | Flags: | j:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-07-02 21:03:19 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 245697 |
Description
Ruben Kerkhof
2007-06-25 21:21:42 UTC
rpmlint has this to say: E: perl-Gearman useless-explicit-provides perl(Gearman::Client) which unfortunately means you have a dependency to filter out. The URL seems invalid; at least I get a 404 when attempting to download it. http://search.cpan.org/CPAN/authors/id/B/BR/BRADFITZ/Gearman-1.08.tar.gz seems to work for me. I can find no license statement of any kind in the code, documentation or upstream web page. How did you determine that "GPL or Artistic" applies? Review: * source files match upstream: bf4fe03657e49cd5109be54d43158d8e3979329f11f1c7de4420b9d4afc1a8b7 Gearman-1.08.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. ? license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly X rpmlint has a valid complaint. X final provides and requires are sane: perl(Gearman::Client) perl(Gearman::Client) = 1.08 perl(Gearman::Job) perl(Gearman::JobStatus) perl(Gearman::Objects) perl(Gearman::ResponseParser) perl(Gearman::ResponseParser::Taskset) perl(Gearman::Task) perl(Gearman::Taskset) perl(Gearman::Util) perl(Gearman::Worker) perl-Gearman = 1.08-1.fc8 = perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Gearman::Client) perl(Gearman::JobStatus) perl(Gearman::Objects) perl(Gearman::ResponseParser::Taskset) perl(Gearman::Task) perl(Gearman::Taskset) perl(Gearman::Util) perl(IO::Socket::INET) perl(Scalar::Util) perl(Socket) perl(String::CRC32) perl(Time::HiRes) perl(base) perl(fields) perl(strict) * %check is present and all runnable tests pass, but not many of them run because they require a running server to test against. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. Hi Jason, thanks for the review > rpmlint has this to say: > E: perl-Gearman useless-explicit-provides perl(Gearman::Client) > which unfortunately means you have a dependency to filter out. Good catch, fixed > The URL seems invalid Ah, this is what cpanspec generates. Fixed. > I can find no license statement of any kind in the code, documentation or upstream web page. > How did you determine that "GPL or Artistic" applies? I tried to prove it mathematically, but somehow failed ;-) I've just mailed the author, hope to hear from him soon. New version: http://rubenkerkhof.com/packages/perl-Gearman.spec http://rubenkerkhof.com/packages/perl-Gearman-1.08-2.fc7.src.rpm The package now includes the license. New version: http://rubenkerkhof.com/packages/perl-Gearman.spec http://rubenkerkhof.com/packages/perl-Gearman-1.09-1.fc7.src.rpm Great! rpmlint output is now clean, the errant provided symbol is gone, and the license is now obvious. APPROVED New Package CVS Request ======================= Package Name: perl-Gearman Short Description: Distributed job system Owners: ruben Branches: F-6 F-7 cvs done. Note that you are supposed to set the fedora-cvs flag to ?, not +. :) Thanks Kev, I must have been sleeping ackage Change Request ====================== Package Name: perl-Gearman New Branches: EL-4 EL-5 cvs done. Package Change Request ====================== Package Name: perl-Gearman Branches: f15 f14 New InitialCC: perl-sig Please add `perl-sig' to CC list for all Fedora branches as this is Perl package. This is now done via pkgdb. |