Bug 245879
| Summary: | Review Request: stardict-dic-ja - Japanese(ja) dictionaries for StarDict | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Hu Zheng <zhu> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
wtogami: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.4.2-3.fc7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-07-05 19:22:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Hu Zheng
2007-06-27 05:40:18 UTC
MUSTFIX:
Use %{_datadir} instead of /usr/share on these occations:
mkdir -p ${RPM_BUILD_ROOT}/usr/share/stardict/dic
cp -rf stardict-* ${RPM_BUILD_ROOT}/usr/share/stardict/dic/
OK. Fixed as the same file. Thank you! :) Notice, because of bandwidth issue, I didn't upload the newest SRPM, you can download the old srpm, replace the spec file with the newest one and rebuild to get the newest srpm file. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 0aa46b7d589a01663c3fb465152db85d stardict-edict-2.4.2.tar.bz2 e0f60d6acc4e3df6784805816b2e136f stardict-jmdict-en-ja-2.4.2.tar.bz2 2c574aef86a5d7bab45395d7e8ee7f6b stardict-jmdict-ja-en-2.4.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - License text is NOT included in package. - no %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Requires: stardict >= 2.4.2 APPROVED. New Package CVS Request ======================= Package Name: stardict-dic-ja Short Description: Japanese(ja) dictionaries for StarDict Owners: zhu Branches: F-7 InitialCC: stardict-dic-ja-2.4.2-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |