Bug 2459725

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10348494
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2459725-ly/fedora-rawhide-x86_64/10348494-ly/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hi,

I will take this one initially. Review to follow shortly.

Regards

Phil

Hi,

Builds locally and on COPR are good. We you be looking into enabling architectures currently excluded?

RPM Lint: ome issues to review.

Rpmlint
-------
Checking: ly-1.3.2-1.fc45.x86_64.rpm
          ly-1.3.2-1.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmphcmy3arn')]
checks: 32, packages: 2

ly.src: E: spelling-error ('ncurses', '%description -l en_US ncurses -> nurses, curses, n curses')
ly.src: E: spelling-error ('systemd', '%description -l en_US systemd -> systems, system, system d')
ly.x86_64: E: spelling-error ('ncurses', '%description -l en_US ncurses -> nurses, curses, n curses')
ly.x86_64: W: position-independent-executable-suggested /usr/bin/ly
ly.x86_64: W: non-conffile-in-etc /etc/ly/custom-sessions/README
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/ar.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/cat.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/cs.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/de.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/en.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/es.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/fr.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/it.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/ja_JP.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/lv.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/pl.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/pt.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/pt_BR.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/ro.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/ru.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/sr.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/sv.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/tr.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/uk.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/lang/zh_CN.ini
ly.x86_64: W: non-conffile-in-etc /etc/ly/setup.sh
ly.x86_64: W: non-conffile-in-etc /etc/pam.d/ly
ly.x86_64: W: non-conffile-in-etc /etc/pam.d/ly-autologin
ly.spec: W: no-%check-section
ly.src: W: inconsistent-file-extension ly-1.3.2-vendor.tar.zst
 2 packages and 0 specfiles checked; 3 errors, 27 warnings, 8 filtered, 3 badness; has taken 0.2 s 

Regards

Phil

@philip.wyett 

Hi Phil,
Thanks for the review.

For the architecture:
  ExclusiveArch: %{zig_arches}
because the package requires Zig >= 0.15 and Fedora's Zig macros currently only list the architectures where Zig is available. I would prefer to keep this tied to %{zig_arches} for now, and I am happy to enable more architectures once Zig is available and the package builds there.

* The spelling warnings for "ncurses" and "systemd" are false positives.
* Upstream does not appear to ship a full test suite.
* I will look into enabling PIE for the Zig executable, likely by setting PIE in the Zig build or passing the appropriate Zig build option.
* The vendor tarball warning appears to be against the upstream-provided vendor.tar.zst archive.

I will upload an updated SRPM after these changes and trigger a new fedora-review-service build.

Spec URL: https://raw.githubusercontent.com/U2FsdGVkX1/ly-fedora/refs/heads/main/ly.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/u2fsdgvkx1/ly/srpm-builds/10393148/ly-1.3.2-1.src.rpm

Hi,

Thanks for the upload.

The spelling issues can be ignore from rpmlint.

The line below is hinting to build a Position Independent Executable (PIE). This is encouraged.

ly.x86_64: W: position-independent-executable-suggested "/usr/bin/ly"

The lines below.

ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/ar.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/cat.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/cs.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/de.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/en.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/es.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/fr.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/it.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/ja_JP.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/lv.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/pl.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/pt.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/pt_BR.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/ro.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/ru.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/sr.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/sv.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/tr.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/uk.ini
ly.x86_64: W: conffile-without-noreplace-flag /etc/ly/lang/zh_CN.ini

Have you looked at taking package ownership of "/etc/ly" with my %dir.

Have you looked at prepending lines %config or %config(noreplace).

Regards

Phil

Hi Phil,

Thanks, I updated the spec and rebuilt it in mock.

The PIE issue should be fixed now.  The built binary is reported as:

  Type: DYN (Position-Independent Executable file)

I also fixed the /etc handling by explicitly owning the /etc/ly directories and marking the editable files there as %config(noreplace).

Spec URL: https://raw.githubusercontent.com/U2FsdGVkX1/ly-fedora/refs/heads/main/ly.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/u2fsdgvkx1/ly/srpm-builds/10405086/ly-1.3.2-1.src.rpm

[fedora-review-service-build]

Created attachment 2138553 [details]
The .spec file difference from Copr build 10348494 to 10405288

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10405288
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2459725-ly/fedora-rawhide-x86_64/10405288-ly/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hi,

Many thanks for working with the review and making changes where necessary.

I am happy and will mark the package '+', allowing you to create repo and import the package rpm etc. You are in the 'packager' group, so I will not school when schooling is not needed.

Regards

Phil

Thank you so much for your review!

The Pagure repository was created at https://src.fedoraproject.org/rpms/ly
Monitoring:
Anitya project is accessible by this link 
`https://release-monitoring.org/project/371742`
 you can modify it manually.
Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.

Built in rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=2989072