Bug 246286
| Summary: | Review Request: xcb-proto - XCB protocol descriptions | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Jackson <ajax> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cmarcelo, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-07-09 15:31:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adam Jackson
2007-06-29 20:06:11 UTC
Ugh, wrong URLs: http://people.redhat.com/ajackson/xcb/xcb-proto.spec http://people.redhat.com/ajackson/xcb/xcb-proto-1.0-1.fc8.src.rpm I'm going to treat this as a development package, since that's really what it is. Thus the only rpmlint complaint: W: xcb-proto devel-file-in-non-devel-package /usr/share/pkgconfig/xcb-proto.pc is not problematic. It might be nice to define XCB in the description as a courtesy to those who might stumble across this package. Nothing seems to own /usr/share/xcb. That's the only real issue I see. * source files match upstream: df3ce807139957a9d3bd196a6eb5fad1d04af079d47b0ec36502911520b84e08 xcb-proto-1.0.tar.bz2 * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (none) * %clean is present. * package builds in mock (development, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: xcb-proto = 1.0-1.fc8 = pkgconfig * %check is not present; there's nothing to test. X doesn't own /usr/share/scb * doesn't own any directories it shouldn't. * no duplicates in %files. file permissions are appropriate. * no scriptlets present. * no code, but acceptable content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. Updated spec and srpm in the same place as before. Changes:
- update Description to be informative
- document the motivation for the --libdir=%{_datadir} hack
- add %dir %{_datadir}/xcb
OK, this looks good to me. APPROVED New Package CVS Request ======================= Package Name: xcb-proto Short Description: XCB protocol descriptions Owners: ajackson Branches: InitialCC: cvs done. Imported and built. Thanks all! Package Change Request ====================== Package Name: xcb-proto New Branches: F-7 cvs done. |