Bug 2463223
| Summary: | Review Request: rust-salsa - Generic framework for on-demand, incrementalized computation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ben Beasley <code> | ||||
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | decathorpe, package-review | ||||
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2026-05-05 20:42:33 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 2463208, 2463211 | ||||||
| Bug Blocks: | 2461621, 2463427 | ||||||
| Attachments: |
|
||||||
|
Description
Ben Beasley
2026-04-27 14:09:51 UTC
Taking this review. Package was generated with rust2rpm, simplifying the review.
Configuration / manual modifications are well-documented and reasonable. If you haven't already, it might be nice to submit a PR upstream to fix the files that have CRLF line endings.
You might want to exclude other files too ("/justfile", "/release-plz.toml", "/RELEASES.md", "/.dir-locals.el", "/.devcontainer/", "/.github/"), but having these files doesn't hurt. (The last one looks like leftover from ancient times, the changelog is now in ... CHANGELOG.md.)
===
✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org:
project: $crate
homepage: https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter (*NOT* pre-release filter): alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- set bugzilla assignee overrides to @rust-sig (optional)
Thank you for the review! https://release-monitoring.org/project/389787/ > If you haven't already, it might be nice to submit a PR upstream to fix the files that have CRLF line endings. Sure, why not? Let’s see if it sticks. https://github.com/salsa-rs/salsa/pull/1092 > You might want to exclude other files too ("/justfile", "/release-plz.toml", "/RELEASES.md", "/.dir-locals.el", "/.devcontainer/", "/.github/"), but having these files doesn't hurt. (The last one looks like leftover from ancient times, the changelog is now in ... CHANGELOG.md.) Reasonable enough. https://github.com/salsa-rs/salsa/pull/1091 The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-salsa Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` FEDORA-2026-c25e55a76d (rust-salsa-0.26.1-3.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-c25e55a76d FEDORA-2026-c25e55a76d (rust-salsa-0.26.1-3.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report. |