Bug 246460

Currently working on bug 241403 as my primary sponsorship bug.

Being sponsored by mtasaka.u-tokyo.ac.jp (bug 241403)

Very rapid comment:
* Don't write the packages to Requires explicitly which are selected
  by the dependency check of the libraries checked by rpmbuild itself.
  Perhaps all the Requires currently written is not needed.

( Currently I may have no time to review this)

(In reply to comment #3)
> Very rapid comment:
> * Don't write the packages to Requires explicitly which are selected
>   by the dependency check of the libraries checked by rpmbuild itself.
>   Perhaps all the Requires currently written is not needed.

Sorry about that; fixed up now.

> ( Currently I may have no time to review this)

No problems.  Thanks for the sponsorship.


Spec URL: 
http://www.silfreed.net/download/repo/packages/qtpfsgui/qtpfsgui.spec
SRPM URL: 
http://www.silfreed.net/download/repo/packages/qtpfsgui/qtpfsgui-1.8.9-3.src.rpm

%changelog
* Mon Jul 02 2007 Douglas E. Warner <silfreed> 1.8.9-3
- removing explicit Requires

Looks good to me, I was going to submit this myself.  My suggestions, though you
don't have to follow them:

The summary could be a bit less cryptic:

  A graphical tool for creating and tone-mapping HDR images

..and the description should say a bit more:

  Qtpfsgui is a graphical program for assembling bracketed photos into High
  Dynamic Range (HDR) images.  It also provides a number of tone-mapping
  operators for creating low dynamic range versions of HDR images.

I would fix the newlines in %prep and not %install, but this isn't important.

You can call 'desktop-file-install' with '--delete-original', then you don't
have to manually delete it afterwards

(In reply to comment #5)
> The summary could be a bit less cryptic:
> 
>   A graphical tool for creating and tone-mapping HDR images
> 
> ..and the description should say a bit more:
> 
>   Qtpfsgui is a graphical program for assembling bracketed photos into High
>   Dynamic Range (HDR) images.  It also provides a number of tone-mapping
>   operators for creating low dynamic range versions of HDR images.

Thanks for the improved summary and description; I was having a hard time 
coming up with decent ones myself (as you saw ;).

> I would fix the newlines in %prep and not %install, but this isn't 
important.

Okay.  Is there any general guideline as to what should be done in %prep and 
what should be done in %install?  I've mostly kept my %prep sections to 
run %setup and %patch, but since I was just fixing a file that was being 
pulled in by %doc, I could see how it would make more sense to be moved there 
since it wasn't being installed by %install.

> You can call 'desktop-file-install' with '--delete-original', then you don't
> have to manually delete it afterwards

Excellent!  I'll pull that in as well.

I should have new packages up shortly.

Currently uploading the spec file.

Spec URL: 
http://www.silfreed.net/download/repo/packages/qtpfsgui/qtpfsgui.spec
SRPM URL: 
http://www.silfreed.net/download/repo/packages/qtpfsgui/qtpfsgui-1.8.9-4.src.rpm

%changelog
* Wed Jul 04 2007 Douglas E. Warner <silfreed> 1.8.9-4
- cleaning up summary and description
- fixing newlines in prep instead of install
- updating desktop-file-install to call --delete-original to remove that
  manual step

(In reply to comment #6)
> Okay.  Is there any general guideline as to what should be done in %prep and 
> what should be done in %install?

Not anywhere I know.  The packaging guidelines do suggest fixing newline
characters in %prep, though I'm sure it doesn't make any practical difference
where you do it:

http://fedoraproject.org/wiki/Packaging/Guidelines#head-41d4336fa1af8d74500eb89d3a22410cccc4117d

Assigning.

For 1.8.9-4.fc8: almost okay.

* Timestamps
  - Keep timestamps on files under %_datadir/%name/html.
    For this package, the following should work
--------------------------------------------------------
make install -e INSTALL_ROOT=%{buildroot} COPY="cp -pf"
--------------------------------------------------------
    (Check the file "Makefile" on top builddir).

* GTK icon cache
  - Needs updating (please check: "GTK+ icon cache" of
    http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )

* Documents
  - "INSTALL" is for people who want to rebuild this package
    by themselves andd is not needed for rpm users.

Spec URL: 
http://www.silfreed.net/download/repo/packages/qtpfsgui/qtpfsgui.spec
SRPM URL: 
http://www.silfreed.net/download/repo/packages/qtpfsgui/qtpfsgui-1.8.9-5.src.rpm

%changelog
* Tue Jul 10 2007 Douglas E. Warner <silfreed> 1.8.9-5
- preserving timestamps on install
- removed INSTALL file from docs
- updating GTK icon cache

Okay.

-----------------------------------------------
  This package (qtpfsgui) is APPROVED by me
-----------------------------------------------

New Package CVS Request
=======================
Package Name: qtpfsgui
Short Description: A graphical tool for creating and tone-mapping HDR images
Owners: silfreed
Branches: FC-6 F-7

cvs done.

qtpfsgui-1.8.9-5.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.

qtpfsgui-1.8.9-5.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.