Bug 246660

+++ This bug was initially created as a clone of Bug #246595 +++

email from Steve French:

CIFS code was changing the wrong global variable for signing (the old
one, used only by dead, soon to be removed, code in
fs/cifs/connect.c).  Eventually I need to test ntlm, ntlmv2 etc.
override on command line (with or without the "i" integrity checking
option ie ntlmi ... ntlm with signing etc.)

Comments?

-------[snip]------

not being very familiar with this piece of code, I asked a question:

> Looks pretty straightforward, though this is not an area of code I'm
> very familiar with. Does this mean that integrity checking options are
> broken in recent CIFS versions? Were they working before?


Integrity checking is working if the server is configured to require
it (the most common case) - but the client options that would force it
on were broken.  Signing works for NTLM authentication (most common,
and default)

There is a patch to fix signing for the newer NTLMv2 case (posted to
mainling list) that I am testing now.

--------[snip]--------------

not a catastrophic bug, but would be nice to have. Attached is the (so far,
untested by me) patch sent by Steve F.

-- Additional comment from jlayton on 2007-07-03 06:50 EST --
Created an attachment (id=158420)
patch -- fix sign mount option