Bug 2467299

Spec URL: https://raw.githubusercontent.com/srikrishnaveturi/rust-rbpf-fedora/main/rust-rbpf.spec

SRPM URL: https://github.com/srikrishnaveturi/rust-rbpf-fedora/raw/main/rust-rbpf-0.4.1-1.fc42.src.rpm

Description: Virtual machine and JIT compiler for eBPF programs. This package is needed as a dependency for aya-obj and aya, which are required for onboarding Azure Guest Proxy Agent to Fedora.

Fedora Account System Username: sveturi

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10551683
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2467299-rust-rbpf/fedora-rawhide-x86_64/10551683-rust-rbpf/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Standard Rust packaging, seems all legit.

I see at least one issue that should have blocked approval: The built packages are not all installable.

In particular, the "cranelift" feature pulls in the cranelift compiler infrastructure, which isn't packaged for Fedora.
That feature will need to be hidden (or cranelift needs to get packaged, if it's actually needed for aya).

I would also recommend to persist the configuration for which tests are / can be run in a rust2rpm.toml config file.

Both things can be achieved with a rust2rpm.toml file with these contents:

```
[features]
hide = ["cranelift"]

[tests]
run = [
    "lib",
    "test:assembler",
    "test:disassembler",
    "test:misc",
    "test:ubpf_verifier",
    "test:ubpf_vm",
]
comments = [
    """\
    JIT tests (ubpf_jit_x86_64) and JIT doctests require mprotect(PROT_EXEC|PROT_WRITE)
    which is denied by SELinux deny_execmem policy in mock/Koji.
    Run lib unit tests + all safe integration tests, skip JIT and doctests.""",
]
```

see man(5) rust2rpm.toml for documentation of the config file format.

I have updated the spec to address review feedback:
- Added rust2rpm.toml to hide the "cranelift" feature (unpackaged deps) and persist test configuration
- Regenerated spec with rust2rpm

Spec URL: https://raw.githubusercontent.com/srikrishnaveturi/rust-rbpf-fedora/main/rust-rbpf.spec

SRPM URL: https://github.com/srikrishnaveturi/rust-rbpf-fedora/raw/main/rust-rbpf-0.4.1-1.fc42.src.rpm

Description: Virtual machine and JIT compiler for eBPF programs. This package is needed as a dependency for aya-obj and aya, which are required for onboarding Azure Guest Proxy Agent to Fedora.

Fedora Account System Username: sveturi

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10661410
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2467299-rust-rbpf/fedora-rawhide-x86_64/10661410-rust-rbpf/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Hi @decathorpe, 

I have updated the files and the new builds have succeeded. Can you please take a look at this request again? Thank you for your help!

Looks good to me now, thanks.

zbyszek, do you want to do the fedora-review+ flag, or should I do it?

Hi @decathorpe @zbyszek.pl 

Please help me approve and merge this request. Some other requests I need to create are also dependent on this request so I would really appreciate your help here!

I'm on vacation until the end of the week. Fabio, if you could take care of this, that'd be great. Otherwise, I can do it next week.

Thanks, I've now set the appropriate flags.

Thank you, is this package now considered approved and would the next step be to find a sponsor for this package?

Correct, though in contrast to other distributions, Fedora sponsors people, not packages - so the future maintainer of this package in Fedora needs to be sponsored, not *this package* per se.

*** Bug 2437525 has been marked as a duplicate of this bug. ***

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rbpf
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rbpf
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`