Bug 246920

Summary: Initscript Review for ez-ipupdate
Product: [Fedora] Fedora Reporter: Harald Hoyer <harald>
Component: ez-ipupdateAssignee: Jeff Layton <jlayton>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: steved
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 3.0.11-0.15.b8 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-07-15 11:32:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 246824    

Description Harald Hoyer 2007-07-05 13:50:02 UTC 
Please have a look at the wikipage 
http://fedoraproject.org/wiki/FCNewInit/Initscripts
and change your initscripts to comply with the LSB standard.
Especially check the exit status and add a LSB Header.
E.g. starting a service should return with 0, if the service is already running and stopping a stopped service should also return with 0.

Also check, if your service has to be _on_ per default, and turn it off in the old chkconfig line, if not.

Thank you.
Comment 1 Jeff Layton 2007-07-11 01:14:02 UTC 
Hmm, this is trickier than it looks at first glance. Given that the init script
can start multiple daemons, I suppose we need to error out when any one of them
fails. I'm also not sure that we handle the situation correctly when start is
run on an already running daemon, etc.
Comment 2 Jeff Layton 2007-07-15 11:32:20 UTC 
Changes committed in version 3.0.11-0.15.b8