Bug 247039

Summary:	Initscript Review
Product:	[Fedora] Fedora	Reporter:	Harald Hoyer <harald>
Component:	qpidc	Assignee:	Alan Conway <aconway>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	low
Version:	rawhide	CC:	meyering, nsantos
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-08-31 12:05:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	246824

Description Harald Hoyer 2007-07-05 13:57:40 UTC

Please have a look at the wikipage 
http://fedoraproject.org/wiki/FCNewInit/Initscripts
and change your initscripts to comply with the LSB standard.
Especially check the exit status and add a LSB Header.
E.g. starting a service should return with 0, if the service is already running and stopping a stopped service should also return with 0.

Also check, if your service has to be _on_ per default, and turn it off in the old chkconfig line, if not.

Thank you.

Comment 1 Alan Conway 2007-08-31 12:05:48 UTC

Completed by Jim Meyering

------------------------------------------------------------------------
r554659 | meyering | 2007-07-09 16:26:42 +0200 (Mon, 09 Jul 2007) | 11 lines

        Update for Fedora init-scripts guidelines:
        <http://fedoraproject.org/wiki/FCNewInit/Initscripts>
        * etc/qpidd: Provide an LSB header.
        Allow options to be specified via QPIDD_OPTIONS=...
          in /etc/sysconfig/qpidd.
        Diagnose and 'exit 3' for the unsupported "reload".
        Don't mention unused $pidfile.
        Remove useless curly braces: ${lockfile} -> $lockfile.
        Write usage and error diagnostics to stderr, not stdout.
        Change spelling: condrestart -> try-restart.