Bug 247405
Summary: | Review Request: compiz-bcop - Compiz option code generator | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Mohd Izhar Firdaus Ismail <mohd.izhar.firdaus> |
Component: | Package Review | Assignee: | Stewart Adam <s.adam> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, jarod, lxtnow, notting |
Target Milestone: | --- | Flags: | s.adam:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-08-25 18:42:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 247406 |
Description
Mohd Izhar Firdaus Ismail
2007-07-09 04:13:52 UTC
There's three changes that need to be made to the package: - Rpmlint isn't silent: W: compiz-bcop non-standard-group Application/Development The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support". E: compiz-bcop zero-length /usr/share/doc/compiz-bcop-0.1.3/ChangeLog E: compiz-bcop zero-length /usr/share/doc/compiz-bcop-0.1.3/README ** These two errors are OK W: compiz-bcop devel-file-in-non-devel-package /usr/share/pkgconfig/bcop.pc W: compiz-bcop non-standard-group Application/Development W: compiz-bcop incoherent-version-in-changelog 0.1.3-0.4.20070703git 0.1.3-0.5.20070708git.fc7 - /usr/share/bcop/ isn't owned by any package. - /usr/share/pkgconfig/bcop.pc must be moved to a devel package Fixed the group entry , http://devel.foss.org.my/~kagesenshi/repo/private/testing/compiz-bcop/compiz-bcop-0.1.3-0.6.20070711git.fc7.src.rpm I have a question about devel package, compiz-bcop is used only by people who are going to build compiz plugins and the package only contains 3 files. A shell script, a xslt file, and the .pc file (which is mainly to tell Makefiles of compiz plugins that the bcop script is installed). Is it really required to separate the script and the pkgconfig file to different rpms? I would say so, but ask this on #fedora-devel to be sure/for the exception. Since this package will only ever be used as a BR it makes no sense to separate those files out. so s.adam , do I need to separate or not? No, ignacio (ivazquez) has much more experience than me in this area, let's follow his advice. The remaining rpmlint errors from the SRPM in comment #2 are safe to ignore. ACCEPTED I forgot to mention that this is my first package and need a sponsor .. anyway .. it seems like Adel Gadllah already pushed his compiz-bcop package to rawhide .. and most probably he'll be maintaining the whole compiz-fusion package set .. guess i'll leave the rest to him bug closed |