Bug 247704

Summary:	Review Request: gifsicle - Powerful program for manipulating GIF images and animations
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	pertusus: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-07-11 16:33:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	216536

Description Orion Poplawski 2007-07-10 20:21:53 UTC

Spec URL: http://www.cora.nwra.com/~orion/fedora/gifsicle.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/gifsicle-1.48-1.src.rpm
Description: 
Gifsicle is a command-line tool for creating, editing, and getting
information about GIF images and animations.

Some more gifsicle features:

    * Batch mode for changing GIFs in place.
    * Prints detailed information about GIFs, including comments.
    * Control over interlacing, comments, looping, transparency...
    * Creates well-behaved GIFs: removes redundant colors, only uses local
      color tables if it absolutely has to (local color tables waste space
      and can cause viewing artifacts), etc.
    * It can shrink colormaps and change images to use the Web-safe palette
      (or any colormap you choose).
    * It can optimize your animations! This stores only the changed portion
      of each frame, and can radically shrink your GIFs. You can also use
      transparency to make them even smaller. Gifsicle?s optimizer is pretty
      powerful, and usually reduces animations to within a couple bytes of
      the best commercial optimizers.
    * Unoptimizing animations, which makes them easier to edit.
    * A dumb-ass name.

Two other programs are included with gifsicle: gifview is a lightweight
animated-GIF viewer which can show animations as slideshows or in real time,
and gifdiff compares two GIFs for identical visual appearance.

Comment 1 Patrice Dumas 2007-07-10 20:50:28 UTC

* rpmlint is silent
* free software, license included. 
CLP is BSD-like, the remaining is GPL. Some portability files 
don't have copyright holder, are simple and may be considered
public domain, in my opinion.
* follow packaging guidelines
* match upstream
3857d3d920180f2b9bac32c7b1a2e276  gifsicle-1.48.tar.gz
* Sane Provides
* %files section right
* build and work fine on devel

You should keep the timestamp of the source tarball, for example
with wget -N or spectool -g.

$ ls -l gifsicle-1.48.tar.gz ../SOURCES/gifsicle-1.48.tar.gz 
-rw-rw-r-- 1 dumas dumas 248110 mar 17 00:00 gifsicle-1.48.tar.gz
-rw-r--r-- 1 dumas dumas 248110 jui 10 21:35 ../SOURCES/gifsicle-1.48.tar.gz

This is not a blocker.

You could consider putting gifview in a separate package if
you want to avoid the dependency on X libraries, but I think
this should be left to you.

APPROVED

Comment 2 Orion Poplawski 2007-07-10 21:01:57 UTC

(In reply to comment #1)
> You should keep the timestamp of the source tarball, for example
> with wget -N or spectool -g.

Fixed.

> You could consider putting gifview in a separate package if
> you want to avoid the dependency on X libraries, but I think
> this should be left to you.

Good idea, I like that.  I've updated the spec and src.rpm to produce a separate
"gifview" package:

Spec URL: http://www.cora.nwra.com/~orion/fedora/gifsicle.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/gifsicle-1.48-2.src.rpm

Comment 3 Orion Poplawski 2007-07-10 21:04:24 UTC

New Package CVS Request
=======================
Package Name: gifsicle
Short Description: Powerful program for manipulating GIF images and animations
Owners: orion
Branches: F-7 FC-6 EL-5
InitialCC:

Comment 4 Patrice Dumas 2007-07-10 21:09:42 UTC

The gifview description should end with a dot, instead of a comma.

Another comment is that I think the ChangeLog is too detailed to
be usefull, but this is also left to you.

Comment 5 Orion Poplawski 2007-07-10 21:14:31 UTC

(In reply to comment #4)
> The gifview description should end with a dot, instead of a comma.

Oops, fixed.

> Another comment is that I think the ChangeLog is too detailed to
> be usefull, but this is also left to you.

Probably, but I'll keep it.

Comment 6 Kevin Fenzi 2007-07-10 23:08:53 UTC

cvs done.

Comment 7 Orion Poplawski 2007-07-11 16:33:58 UTC

Imported and built for devel.  Added to comps.  Closing.