Bug 247852
| Summary: | Review Request: R-systemfit - Simultaneous Equation Estimation R Package | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
wtogami: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-15 20:16:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Orion Poplawski
2007-07-11 17:59:16 UTC
The URL seems incorrect; I think http://cran.r-project.org/src/contrib/Descriptions/systemfit.html is the right one, or perhaps http://www.systemfit.org/ You'll need a Requires: R there as well. (The template has been updated to reflect that.) rpmlint has the usual two complaints, plus one other: W: R-systemfit file-not-utf8 /usr/share/R/library/systemfit/man/systemfit.Rd.gz This is due to a single u-with-umlaut on line 244 of systemfit.Rd; a call to iconv should fix it up. The checks are very noisy, with many differences shown in the least significant digits. However, it looks to me as if everything comes out OK. * source files match upstream: 3172eda701ed559443f6e8344263e772ea11dd5401108fe61b84a324949643b5 systemfit_0.8-2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently (follows the R example template). * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly X rpmlint has a valid complaint. * final provides and requires are sane: R-systemfit = 0.8-3.fc8 = /bin/sh R * %check is present and all tests pass. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * Thu Jul 12 2007 Orion Poplawski <orion.com> - 0.8-4 - Fix URL - Add Requires: R http://www.cora.nwra.com/~orion/fedora/R-systemfit.spec http://www.cora.nwra.com/~orion/fedora/R-systemfit-0.8-4.src.rpm OK, now it's just down that file-not-utf8 error with systemfit.Rd. (In reply to comment #3) > OK, now it's just down that file-not-utf8 error with systemfit.Rd. Gah, fixed. * Thu Jul 12 2007 Orion Poplawski <orion.com> - 0.8-5 - Convert systemfit.Rd to UTF-8 http://www.cora.nwra.com/~orion/fedora/R-systemfit.spec http://www.cora.nwra.com/~orion/fedora/R-systemfit-0.8-5.src.rpm Looks good now. APPROVED Ping? Sorry, on vacation. New Package CVS Request ======================= Package Name: R-systemfit Short Description: Simultaneous Equation Estimation R Package Owners: orion Branches: F-7 FC-6 EL-5 It looks like this is in rawhide but hasn't been pushed to F7. (I don't see it in the FC-6 extras repository, either.) Do you need assistance getting this package pushed out? Just got pushed to the back burner. Builds are on their way. |