Bug 247894
| Summary: | Review Request: R-multcomp - Simultaneous inference for general linear hypotheses R Package | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orion Poplawski <orion> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
wtogami: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-10-17 20:59:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 247858 | ||
| Bug Blocks: | |||
|
Description
Orion Poplawski
2007-07-11 20:51:25 UTC
The URL is not correct (or at least it gets me a 404); seems like it should be http://cran.r-project.org/src/contrib/Descriptions/%{packname}.html rpmlint has the two usual R package complaints, plus: W: R-multcomp mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 4) which isn't a problem. Again the test suite spews a bunch of diffs but still succeeds. Since the only real issue is the URL, I'll approve this and you can fix it when you check in. * source files match upstream: 58040d741b4036407b4c8f9967b8c163c0ba3bd2eff615f1cf09735f85542f77 multcomp_0.992-2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint has acceptable complaints. * final provides and requires are sane: R-multcomp = 0.992-1.fc8 = /bin/sh R R-mvtnorm * %check is present and all tests pass. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED, just fix the URL. URL fixed. New Package CVS Request ======================= Package Name: R-multcomp Short Description: Simultaneous inference for general linear hypotheses R Package Owners: orion Branches: F-7 FC-6 EL-5 Built (finally). |