Bug 248067
| Summary: | Review Request: opie -- One-time Passwords In Everything | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Woodhouse <dwmw2> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davidf, degts, fedora-package-review, felix, gauret, notting, opensource, sundaram |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-08-20 21:57:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
David Woodhouse
2007-07-12 22:17:46 UTC
What should I put in the 'License' tag? http://dehs.alioth.debian.org/wwiz_detail.php?id=8454741&type=watch I took a quick look at this.
Frankly I have no idea what should be used for the License: tag. spot has been
doing much work in this area so perhaps you could ping him about it.
There's no %check section but I guess the package runs a test suite at make
time. It fails pretty badly for me:
opietest: completed 13 tests. 5 tests passed, 2 tests skipped, 6 tests failed.
opietest: please correct the following failures before attempting to use OPIE:
opieatob8
opieetob
opiegenerator
opiehash(MD4)
opiehash(MD5)
opiekeycrunch
The build does continue after that but it's still troubling. This is a mock
build on x86_64 rawhide; perhaps there are 64 bit issues?
In an i386 Fedora 7 mock buld I get: opietest: completed 13 tests. 11 tests passed, 2 tests skipped, 0 tests failed. On http://fedoraproject.org/wiki/Licensing the NRL License is listed and the license tag should be "BSD with advertising". The TIN License looks pretty similiar in vimdiff, so just ask spot to add the TIN License to the Licensing page. Btw. where does the opiessh.c come from? There are some compiler warnings because of a missing #include <unistd.h> and no return statement for main. I guess "return execv(argv[0],argv);" would be good enough. Hey, are you still interested in this package? Not particularly. I have no need for dealing with the idiocy that is SSH+S/Key any more. I have different idiocy to deal with... I don't mind maintaining the package though -- it should be fairly simple. I wrote opiessh.c, but I can't test it any more. You could, though :) This is very old, and I'm not sure what should happen with it. It seems at this point, with the test failures and license issue unresolved, that it would be better to just close this. If you do want to continue, however, could you address those issues and provide an updated package. Upstream seems dead as well since their website doesn't work anymore. After another month, I'm going ahead and closing this. |