Bug 2480697

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10504406
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2480697-opencloud-desktop-shell-integration-resources/fedora-rawhide-x86_64/10504406-opencloud-desktop-shell-integration-resources/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I'll review it

That's a simple and a clean one. Here is my formal

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Dist tag is present.

^^^ false positive

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license (GPL-2.0-only).
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package does not contains desktop file (not a GUI application).
[-]: No development files.
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: The package is not a rename of another package.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package does not contain systemd file(s).
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 231 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: I did not test if the package functions as described.
[x]: Latest version is packaged (1.0.0).
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources werent verified with gpgverify first in %prep.
[?]: I did not test if the package compiles and builds into binary rpms
     on all supported architectures. Noarch package anyway.
[-]: No %check is required.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: opencloud-desktop-shell-integration-resources-1.0.0-1.fc45.noarch.rpm
          opencloud-desktop-shell-integration-resources-1.0.0-1.fc45.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpafdx2qp0')]
checks: 32, packages: 2

opencloud-desktop-shell-integration-resources.spec: W: no-%check-section
opencloud-desktop-shell-integration-resources.noarch: E: incorrect-fsf-address /usr/share/licenses/opencloud-desktop-shell-integration-resources/COPYING
 2 packages and 0 specfiles checked; 1 errors, 1 warnings, 11 filtered, 1 badness; has taken 0.2 s 

^^^ Should be fixed upstream not us.


Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.9.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

opencloud-desktop-shell-integration-resources.noarch: E: incorrect-fsf-address /usr/share/licenses/opencloud-desktop-shell-integration-resources/COPYING
 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 5 filtered, 1 badness; has taken 0.0 s 



Source checksums
----------------
https://github.com/opencloud-eu/desktop-shell-integration-resources/archive/v1.0.0/opencloud-desktop-shell-integration-resources-1.0.0.tar.gz :
  CHECKSUM(SHA256) this package     : 24108f36c86424e0cd005b44b94f7cf584e3b9eff6631758ab2e335fff5bc60c
  CHECKSUM(SHA256) upstream package : 24108f36c86424e0cd005b44b94f7cf584e3b9eff6631758ab2e335fff5bc60c


Requires
--------
opencloud-desktop-shell-integration-resources (rpmlib, GLIBC filtered):
    cmake-filesystem
    hicolor-icon-theme



Provides
--------
opencloud-desktop-shell-integration-resources:
    cmake(OpenCloudShellResources)
    cmake(opencloudshellresources)
    opencloud-desktop-shell-integration-resources



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2480697
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic
Disabled plugins: Java, fonts, PHP, Perl, R, C/C++, Haskell, Python, SugarActivity, Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


This package is

================
=== APPROVED ===
================