Bug 2481488

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10513639
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2481488-perl-text-jscalendar/fedora-rawhide-x86_64/10513639-perl-Text-JSCalendar/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Source file is ok
Summary is ok
License:
FIX: The license should be Artistic-2.0. It is mention in
     lib/Text/JSCalendar.pm and lib/Text/JSCalendar/TimeZones.pm

Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add build-requires
     perl(Carp) - lib/Text/JSCalendar.pm:6
     perl(Data::Dumper) - lib/Text/JSCalendar.pm:22
     perl(Data::ICal) - lib/Text/JSCalendar.pm:7
     perl(Data::ICal::Entry::Alarm::Display) - lib/Text/JSCalendar.pm:11
     perl(Data::ICal::Entry::Alarm::Email) - lib/Text/JSCalendar.pm:10
     perl(Data::ICal::Entry::Event) - lib/Text/JSCalendar.pm:8
     perl(Data::ICal::Entry::TimeZone) - lib/Text/JSCalendar/TimeZones.pm:22
     perl(Data::ICal::Entry::TimeZone::Daylight) - lib/Text/JSCalendar/TimeZones.pm:23
     perl(Data::ICal::Entry::TimeZone::Standard) - lib/Text/JSCalendar/TimeZones.pm:24
     perl(MIME::Base64) - lib/Text/JSCalendar.pm:18
     perl(URI::Escape) - lib/Text/JSCalendar.pm:21
     perl(HTTP::Request) - t/cyrus-caldav.t:8
     perl(lib) - t/cyrus-caldav.t:10

$ rpm -qp --requires perl-Text-JSCalendar-0.05-1.fc45.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(Data::Dumper)
      1 perl(Data::ICal)
      1 perl(Data::ICal::Entry::Alarm::Display)
      1 perl(Data::ICal::Entry::Alarm::Email)
      1 perl(Data::ICal::Entry::Event)
      1 perl(Data::ICal::Entry::TimeZone)
      1 perl(Data::ICal::Entry::TimeZone::Daylight)
      1 perl(Data::ICal::Entry::TimeZone::Standard)
      1 perl(Data::ICal::TimeZone) >= 1.23
      1 perl(DateTime::Format::ICal) >= 0.09
      1 perl(DateTime::Format::ISO8601) >= 0.08
      1 perl(DateTime::TimeZone)
      1 perl(Digest::SHA)
      1 perl(JSON)
      1 perl(JSON::XS)
      1 perl-libs
      1 perl(MIME::Base64)
      1 perl(MIME::Types)
      1 perl(strict)
      1 perl(Text::JSCalendar::TimeZones)
      1 perl(Text::LevenshteinXS) >= 0.03
      1 perl(Text::VCardFast) >= 0.06
      1 perl(URI::Escape)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Text-JSCalendar-0.05-1.fc45.noarch.rpm | sort | uniq -c
      1 perl(Text::JSCalendar) = 0.05
      1 perl-Text-JSCalendar = 0.05-1.fc45
      1 perl(Text::JSCalendar::TimeZones)
Binary provides are Ok.

$ rpmlint ./perl-Text-JSCalendar*
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Text-JSCalendar.noarch: E: spelling-error ('iCalendar', 'Summary(en_US) iCalendar -> i Calendar, calendar, Carbondale')
perl-Text-JSCalendar.noarch: E: spelling-error ('iCalendar', '%description -l en_US iCalendar -> i Calendar, calendar, Carbondale')
perl-Text-JSCalendar.noarch: E: spelling-error ('ietf', '%description -l en_US ietf -> diet')
perl-Text-JSCalendar.noarch: E: spelling-error ('calext', '%description -l en_US calext -> cal ext, cal-ext, lexical')
perl-Text-JSCalendar.noarch: E: spelling-error ('icalendar', '%description -l en_US icalendar -> calendar, i calendar, legendarily')
perl-Text-JSCalendar.noarch: E: spelling-error ('jscalendarbis', '%description -l en_US jscalendarbis -> legendarily')
perl-Text-JSCalendar.noarch: E: spelling-error ('iCal', '%description -l en_US iCal -> i Cal, Cal, Cali')
perl-Text-JSCalendar.src: E: spelling-error ('iCalendar', 'Summary(en_US) iCalendar -> i Calendar, calendar, Carbondale')
perl-Text-JSCalendar.src: E: spelling-error ('iCalendar', '%description -l en_US iCalendar -> i Calendar, calendar, Carbondale')
perl-Text-JSCalendar.src: E: spelling-error ('ietf', '%description -l en_US ietf -> diet')
perl-Text-JSCalendar.src: E: spelling-error ('calext', '%description -l en_US calext -> cal ext, cal-ext, lexical')
perl-Text-JSCalendar.src: E: spelling-error ('icalendar', '%description -l en_US icalendar -> calendar, i calendar, legendarily')
perl-Text-JSCalendar.src: E: spelling-error ('jscalendarbis', '%description -l en_US jscalendarbis -> legendarily')
perl-Text-JSCalendar.src: E: spelling-error ('iCal', '%description -l en_US iCal -> i Cal, Cal, Cali')
 2 packages and 1 specfiles checked; 14 errors, 0 warnings, 8 filtered, 14 badness; has taken 0.5 s
Rpmlint is ok

Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items and provide a new spec file.

Resolution:
NOT Approved

Update:
Spec URL: https://skim.cz/tmp/perl-Text-JSCalendar-2/perl-Text-JSCalendar.spec
SRPM URL: https://skim.cz/tmp/perl-Text-JSCalendar-2/perl-Text-JSCalendar-0.05-1.fc45.src.rpm

Created attachment 2143084 [details]
The .spec file difference from Copr build 10513639 to 10516666

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10516666
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2481488-perl-text-jscalendar/fedora-rawhide-x86_64/10516666-perl-Text-JSCalendar/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> License:
> FIX: The license should be Artistic-2.0. It is mention in
>      lib/Text/JSCalendar.pm and lib/Text/JSCalendar/TimeZones.pm
@@ -4,3 +4,3 @@
 Summary:        Convert between iCalendar and JSCalendar
-License:        GPL-1.0-or-later OR Artistic-1.0-Perl
+License:        Artistic-2.0
 URL:            https://metacpan.org/dist/Text-JSCalendar
Ok

> BuildRequires
> FIX: Please add build-requires
>      perl(Carp) - lib/Text/JSCalendar.pm:6
>      perl(Data::Dumper) - lib/Text/JSCalendar.pm:22
>      perl(Data::ICal) - lib/Text/JSCalendar.pm:7
>      perl(Data::ICal::Entry::Alarm::Display) - lib/Text/JSCalendar.pm:11
>      perl(Data::ICal::Entry::Alarm::Email) - lib/Text/JSCalendar.pm:10
>      perl(Data::ICal::Entry::Event) - lib/Text/JSCalendar.pm:8
>      perl(Data::ICal::Entry::TimeZone) - lib/Text/JSCalendar/TimeZones.pm:22
>      perl(Data::ICal::Entry::TimeZone::Daylight) -
> lib/Text/JSCalendar/TimeZones.pm:23
>      perl(Data::ICal::Entry::TimeZone::Standard) -
> lib/Text/JSCalendar/TimeZones.pm:24
>      perl(MIME::Base64) - lib/Text/JSCalendar.pm:18
>      perl(URI::Escape) - lib/Text/JSCalendar.pm:21
>      perl(HTTP::Request) - t/cyrus-caldav.t:8
>      perl(lib) - t/cyrus-caldav.t:10
@@ -19,2 +19,11 @@
 # Run-time:
+BuildRequires:  perl(Carp)
+BuildRequires:  perl(Data::Dumper)
+BuildRequires:  perl(Data::ICal)
+BuildRequires:  perl(Data::ICal::Entry::Alarm::Display)
+BuildRequires:  perl(Data::ICal::Entry::Alarm::Email)
+BuildRequires:  perl(Data::ICal::Entry::Event)
+BuildRequires:  perl(Data::ICal::Entry::TimeZone)
+BuildRequires:  perl(Data::ICal::Entry::TimeZone::Daylight)
+BuildRequires:  perl(Data::ICal::Entry::TimeZone::Standard)
 BuildRequires:  perl(Data::ICal::TimeZone) >= 1.23
@@ -26,2 +35,3 @@
 BuildRequires:  perl(JSON::XS)
+BuildRequires:  perl(MIME::Base64)
 BuildRequires:  perl(MIME::Types)
@@ -29,3 +39,6 @@
 BuildRequires:  perl(Text::VCardFast) >= 0.06
+BuildRequires:  perl(URI::Escape)
 # Tests:
+BuildRequires:  perl(HTTP::Request)
+BuildRequires:  perl(lib)
 BuildRequires:  perl(LWP::UserAgent)
Ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Text-JSCalendar
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`