Bug 248516
| Summary: | Review Request: nodoka-theme-gnome - The Nodoka Metacity theme and Gnome metatheme | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Martin Sourada <martin.sourada> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-05 20:41:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 248163 | ||
| Bug Blocks: | |||
|
Description
Martin Sourada
2007-07-17 08:26:35 UTC
Trivia: - please use a full source url, if practical - the emmpty %doc in the file list looks odd, I'd remove that the description of the main package is a bit misleading: "The Nodoka Theme Pack for Gnome includes Nodoka Metacity theme, Nodoka gtk2 theme and Echo Icon set." since it does not actually include these things, but just pull them in via dependencies. (In reply to comment #1) > Trivia: > > - please use a full source url, if practical > Same as with gtk-nodoka-theme: as we currently use wiki for upstream I think it's impractical ATM > - the emmpty %doc in the file list looks odd, I'd remove that > True, removed > the description of the main package is a bit misleading: > "The Nodoka Theme Pack for Gnome includes Nodoka Metacity theme, Nodoka gtk2 > theme and Echo Icon set." > since it does not actually include these things, but just pull them in > via dependencies. Yes, I changed the includes to make use. Seems saner to me... New release: New SPEC: http://feannatar.hostuju.cz/fedora/files/development/SPECS/nodoka-theme-gnome.spec New SRPM: http://feannatar.hostuju.cz/fedora/files/development/SRPMS/nodoka-theme-gnome-0.3.1.1-2.fc7.src.rpm rpmlint is silent on the produced rpms
package name: ok, I think.
spec name: ok
packaging guidelines: mostly ok
- might be a good idea to put a comment pointing to the wiki location
of the upstream sources
- should add a comment about the "inverse relationship" between main
and subpackage, where the main package requires the subpackage
license: ok
license field: ok
license file: ok
spec language: ok
spec legibility: ok
upstream sources: ok
buildable: ok
excludearch: n/a
build deps: ok
locales: n/a
shared libs: n/a
relocatable: n/a
directory ownership: there is a conflict where both the gtk theme package
and the metacity theme package own /usr/share/themes/Nodoka. Possible
solution: make the metacity theme package require the gtk theme package
file list dupes: ok
file permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: n/a
%doc content: ok
header files: n/a
static libs: n/a
pc files: n/a
shared lib symlinks: n/a
devel package: n/a
libtool archives: n/a
gui apps: n/a
file ownership: see above
%install: ok
utf8 filenames: ok
I made a new release addressing the above mentioned issues. New SPEC: http://feannatar.hostuju.cz/fedora/files/development/SPECS/nodoka-theme-gnome.spec New SRPM: http://feannatar.hostuju.cz/fedora/files/development/SRPMS/nodoka-theme-gnome-0.3.1.1-3.fc7.src.rpm Looks fine now. Approved. New Package CVS Request ======================= Package Name: nodoka-theme-gnome Short Description: The Nodoka Metacity theme and Gnome metatheme Owners: martin.sourada Branches: InitialCC: cvs done. |