Bug 2486075

Summary: Review Request: rust-sourceview5-sys - FFI bindings for GtkSourceView 5
Product: [Fedora] Fedora Reporter: Dominik 'Rathann' Mierzejewski <dominik>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: code, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2486076    

Description Dominik 'Rathann' Mierzejewski 2026-06-07 11:35:34 UTC 
Spec URL: https://rathann.fedorapeople.org/review/rust-sourceview5-sys/rust-sourceview5-sys.spec
SRPM URL: https://rathann.fedorapeople.org/review/rust-sourceview5-sys/rust-sourceview5-sys-0.11.0-1.fc45.src.rpm
Description:
GtkSourceView 5 Rust bindings.

Fedora Account System Username: rathann
Comment 1 Ben Beasley 2026-06-17 10:04:40 UTC 
> # FIXME: no license files detected

You have to actually fix this.

https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text

I opened https://gitlab.gnome.org/World/Rust/sourceview5-rs/-/merge_requests/30 to fix the problem upstream. Meanwhile, you can look in .cargo_vcs_info.json to get the git commit corresponding to the release (264a23088491a5c1812e90b41b4926341ff8fe58 for 0.11.0), and then add https://gitlab.gnome.org/World/Rust/sourceview5-rs/-/raw/264a23088491a5c1812e90b41b4926341ff8fe58/LICENSE as an additional source. (You could have written the URL with a tag if upstream tagged releases, but they don’t, so the commit will have to do.) See https://src.fedoraproject.org/rpms/rust-cyclonedx-bom-macros/blob/e0657f4c6db7c95437ed1a02fb99d7995d9ae272/f/rust2rpm.toml for a similar example.

----

> BuildRequires:  pkgconfig(gtksourceview-5)

This appears to be correct, but these bindings will also need pkgconfig(gtksourceview-5) as an install-time dependency: Rust -devel packages are source-only, and any application that depends directly or indirectly on this package will have a transitive need to link the gtksourceview-5 library.

Try this in rust2rpm.toml:

[requires]
build = [
    "pkgconfig(gtksourceview-5)",
]
lib = [
    "pkgconfig(gtksourceview-5)",
]