Bug 248678
| Summary: | Review Request: R-BSgenome.Dmelanogaster.FlyBase.r51 - osophila melanogaster genome (FlyBase r5.1) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pierre-Yves <pingoufc4> |
| Component: | Package Review | Assignee: | Jason Tibbitts <j> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.3.1-3 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2008-01-29 05:18:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Pierre-Yves
2007-07-18 06:29:15 UTC
Changed in the license tag SPEC http://www.pingoured.fr/public/RPM/R-BSgenome.Dmelanogaster.FlyBase.r51/R-BSgenome.Dmelanogaster.FlyBase.r51.spec SRPM http://www.pingoured.fr/public/RPM/R-BSgenome.Dmelanogaster.FlyBase.r51/R-BSgenome.Dmelanogaster.FlyBase.r51-1.2.0-2.fc6.src.rpm (In reply to comment #1) I am not a sponsor, I would like to assist in a pre-review. Please supplly correct spec/srpm URL. Please help yourself, the server should be back by now :) Regards, And of course, by the time I get around to looking at this, the server seems to be down again. Here they are SPEC: http://pingoulaptop.dyndns.org/public/RPM/R-hgu95av2probe/R-hgu95av2probe.spec SRPM: http://pingoulaptop.dyndns.org/public/RPM/R-hgu95av2probe/R-hgu95av2probe-2.0.0-1.fc8.src.rpm oups wrong review :$ Here are the correct uptdated files SPEC: http://pingoulaptop.dyndns.org/public/RPM/R-BSgenome.Dmelanogaster.FlyBase/R-BSgenome.Dmelanogaster.FlyBase.r51.spec SRPM: http://pingoulaptop.dyndns.org/public/RPM/R-BSgenome.Dmelanogaster.FlyBase/R-BSgenome.Dmelanogaster.FlyBase.r51-1.3.1-1.fc8.src.rpm Not much to say here. However, as with the previous genome package you submitted, could you drop the dist tag and do the magic to get only one copy of this package in the distribution? * source files match upstream: 6c76546e300f5325d1e115809db62894aa1f11f598b940f5206ac1d805a077f8 BSgenome.Dmelanogaster.FlyBase.r51_1.3.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint has only the usual R complaints. * final provides and requires are sane: R-BSgenome.Dmelanogaster.FlyBase.r51 = 1.3.1-1.fc9 = /bin/sh R * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (R package registration) * acceptable content * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED New Package CVS Request ======================= Package Name: R-BSgenome.Dmelanogaster.FlyBase.r51 Short Description: osophila melanogaster genome (FlyBase r5.1) Owners: pingou Branches: F-7 F-8 Cvsextras Commits: yes I think the description should be Drosophila melanogaster genome (FlyBase r5.1) oups sorry my mistake ! New Package CVS Request ======================= Package Name: R-BSgenome.Dmelanogaster.FlyBase.r51 Short Description: Drosophila melanogaster genome (FlyBase r5.1) Owners: pingou Branches: F-7 F-8 Cvsextras Commits: yes cvs done. R-BSgenome.Dmelanogaster.FlyBase.r51-1.3.1-3 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update R-BSgenome.Dmelanogaster.FlyBase.r51' R-BSgenome.Dmelanogaster.FlyBase.r51-1.3.1-3 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. |