Bug 248692
Summary: | Review Request: R-rlecuyer - R interface to RNG with multiple streams | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Pierre-Yves <pingoufc4> |
Component: | Package Review | Assignee: | Jason Tibbitts <j> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | j:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | 0.1-3.fc7 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-12-03 05:36:05 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Pierre-Yves
2007-07-18 10:16:36 UTC
*** Bug 248693 has been marked as a duplicate of this bug. *** You have put up many packages for review lately; perhaps you should consider doing some package reviews yourself. I believe there are some R packages up for review which were submitted by someone else. Sorry I was on vacation, I do not mind to do R reviews as I start to know how to do the packages ;-). I have found on the list 2 R package that you have approved by that time, but I will try to keep me in touch with the new R package to review them. For the numbers of package that I submitted to review, most of them are only dependances for other package the R CMD check ask not only for the package required but also for the package suggested (which sometime are only data files http://bioconductor.org/packages/2.0/bioc/html/annotate.html => hgu95av2 is only data file) I do have problems packaging it, each package ask for many dependances and as it is the beginning I have a lot to do to finally being able to package the software of interest... Thanks anyway for your help There is the newest version with the correct license tag : SPEC http://www.pingoured.fr/public/RPM/R-rlecuyer/R-rlecuyer.spec SRPM http://www.pingoured.fr/public/RPM/R-rlecuyer/R-rlecuyer-0.1-2.fc6.src.rpm ++ This package is fine; the only thing I can see is that you don't need the manual R dependency for arch-specific R packages because rpm will find the libR.so dependency on its own. * source files match upstream: 94aaeb5fb7b164223fc71f3d9813ce5a75c88cf7ff18521ab6012a5039511f9f rlecuyer_0.1.tar.gz * package meets naming and versioning guidelines. * package follows R packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * debuginfo package looks complete. * rpmlint has only the expected complaints. * final provides and requires are sane (extraneous R dependency): rlecuyer.so()(64bit) R-rlecuyer = 0.1-2.fc9 = /bin/sh ? R libR.so()(64bit) * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED New Package CVS Request ======================= Package Name: R-rlecuyer Short Description: R interface to RNG with multiple streams Owners: pingou Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes cvs done. R-rlecuyer-0.1-3.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update R-rlecuyer' R-rlecuyer-0.1-3.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update R-rlecuyer' R-rlecuyer-0.1-3.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. R-rlecuyer-0.1-3.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. |