Bug 2489104

Summary:	Review Request: rust-rustdoc-types - Types for rustdoc's json output
Product:	[Fedora] Fedora	Reporter:	Ben Beasley <code>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2026-06-22 13:46:14 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2489105

Description Ben Beasley 2026-06-16 08:48:49 UTC

Spec URL: https://music.fedorapeople.org/rust-rustdoc-types.spec
SRPM URL: https://music.fedorapeople.org/rust-rustdoc-types-0.57.3-1.fc44.src.rpm
Description: Types for rustdoc's json output.
Fedora Account System Username: music

This is a dependency for rust-cargo-semver-checks (cargo-semver-checks → trustfall_rustdoc → trustfall-rustdoc-adapter → rustdoc-types).

Unusually, cargo-semver-checks depends on trustfall_rustdoc with both the v56 and v57 features, so we will need rust-rustdoc-types and rust-trustfall-rustdoc-adapter version 0.57.x/57.x, and simultaneously rust-rustdoc-types0.56 and rust-trustfall-rustdoc-adapter56 compat packages, so I’ll be requesting a compat package as soon as I import this. There should be no packaging differences in the compat package.

Comment 1 Fabio Valentini 2026-06-22 13:23:42 UTC

Package was generated with rust2rpm, simplifying the review.

Version 0.57.4 was released since initial submission, it would be nice if the package could be rebased to that version (unless that makes things more complicated unnecessarily).

It looks like the only relevant change is a change from bincode to postcard in dev-dependencies.

And no, rpmlint, "json" is not a typo.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
🫤 latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 2 Ben Beasley 2026-06-22 13:29:07 UTC

Thank you for the review!

https://release-monitoring.org/project/390795/

Looks like the only change in 0.57.4 is porting a ser/de test from bincode to postcard, which helps ever so slightly with https://forge.fedoraproject.org/rust/backlog/issues/6. I’ll update on import.

https://github.com/rust-lang/rustdoc-types/compare/v0.57.3...v0.57.4

Comment 3 Fedora Admin user for bugzilla script actions 2026-06-22 13:29:46 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rustdoc-types
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 4 Fedora Update System 2026-06-22 13:43:23 UTC

FEDORA-2026-e9d4db5884 (rust-rustdoc-types-0.57.4-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-e9d4db5884

Comment 5 Fedora Update System 2026-06-22 13:46:14 UTC

FEDORA-2026-e9d4db5884 (rust-rustdoc-types-0.57.4-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.