Bug 2489105

Summary: Review Request: rust-trustfall-rustdoc-adapter - Trustfall query adapter for rustdoc JSON data
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-06-30 19:28:17 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2489104, 2489111    
Bug Blocks: 2489112    
Attachments:
Description Flags
Configuration file for rust2rpm
none
Configuration file for rust2rpm
none
Configuration file for rust2rpm none

Description Ben Beasley 2026-06-16 08:51:31 UTC
Created attachment 2145524 [details]
Configuration file for rust2rpm

Spec URL: https://music.fedorapeople.org/rust-trustfall-rustdoc-adapter.spec
SRPM URL: https://music.fedorapeople.org/rust-trustfall-rustdoc-adapter-57.0.7-1.fc44.src.rpm
Description: Trustfall query adapter for rustdoc JSON data.
Fedora Account System Username: music

This is a dependency for rust-cargo-semver-checks (cargo-semver-checks → trustfall_rustdoc → trustfall-rustdoc-adapter).

Unusually, cargo-semver-checks depends on trustfall_rustdoc with both the v56 and v57 features, so we will need rust-rustdoc-types and rust-trustfall-rustdoc-adapter version 0.57.x/57.x, and simultaneously rust-rustdoc-types0.56 and rust-trustfall-rustdoc-adapter56 compat packages, so I’ll be requesting a compat package as soon as I import this. There should be no packaging differences in the compat package.

Comment 1 Ben Beasley 2026-06-16 08:55:12 UTC
Created attachment 2145526 [details]
Configuration file for rust2rpm

Comment 2 Fabio Valentini 2026-06-29 14:36:24 UTC
This no longer builds due to a package update that happened in the meantime:

Problem 1: nothing provides requested (crate(cargo_toml/default) >= 0.22.3 with crate(cargo_toml/default) < 0.23.0~)
Problem 2: nothing provides requested (crate(cargo_toml/features) >= 0.22.3 with crate(cargo_toml/features) < 0.23.0~)

Comment 3 Ben Beasley 2026-06-30 09:37:18 UTC
(In reply to Fabio Valentini from comment #2)
> This no longer builds due to a package update that happened in the meantime:

Patched.

Spec URL: https://music.fedorapeople.org/20260630/rust-trustfall-rustdoc-adapter.spec
SRPM URL: https://music.fedorapeople.org/20260630/rust-trustfall-rustdoc-adapter-57.0.7-1.fc44.src.rpm

Comment 4 Ben Beasley 2026-06-30 09:37:45 UTC
Created attachment 2147131 [details]
Configuration file for rust2rpm

Comment 5 Fabio Valentini 2026-06-30 13:27:46 UTC
Package was generated with rust2rpm, simplifying the review.

There are some scripts in scripts/ that would make sense to exclude.
They cause additional dependencies on /bin/sh and /bin/bash due to their shebangs.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass:
   tests are disabled, the reason is documented and justifiable.
🫤 latest version of the crate is packaged:
   the version corresponding to cargo-semver-checks is needed.
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 6 Ben Beasley 2026-06-30 13:46:21 UTC
Thank you for the review!

> There are some scripts in scripts/ that would make sense to exclude.
> They cause additional dependencies on /bin/sh and /bin/bash due to their
> shebangs.

I will fix this on import.

> 🫤 latest version of the crate is packaged:
>    the version corresponding to cargo-semver-checks is needed.

This *is* the latest version of the trustfall-rustdoc-adapter crate, although the need to immediately create a compat package definitely does merit a 🫤.

https://release-monitoring.org/project/390944/

Comment 7 Fedora Admin user for bugzilla script actions 2026-06-30 13:47:41 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-trustfall-rustdoc-adapter
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 8 Fedora Update System 2026-06-30 14:06:31 UTC
FEDORA-2026-dbe54cb7f1 (rust-trustfall-rustdoc-adapter-57.0.7-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-dbe54cb7f1

Comment 9 Fedora Update System 2026-06-30 19:28:17 UTC
FEDORA-2026-dbe54cb7f1 (rust-trustfall-rustdoc-adapter-57.0.7-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.