Bug 248965
Summary: | lastcomm doesn't display flags | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 4 | Reporter: | Buck Huppmann <buckh> |
Component: | psacct | Assignee: | Ivana Varekova <varekova> |
Status: | CLOSED WONTFIX | QA Contact: | |
Severity: | low | Docs Contact: | |
Priority: | low | ||
Version: | 4.5 | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-05-12 08:20:54 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Buck Huppmann
2007-07-19 21:31:01 UTC
the problem is with psacct-6.3.2-large-uid.patch . it replaces include-ing the system <linux/acct.h>, which contains % grep '#define *A.*0x' /usr/include/linux/acct.h #define AFORK 0x01 /* ... executed fork, but did not exec */ #define ASU 0x02 /* ... used super-user privileges */ #define ACOMPAT 0x04 /* ... used compatibility mode (VAX only not used) */ #define ACORE 0x08 /* ... dumped core */ #define AXSIG 0x10 /* ... was killed by a signal */ with its own acct.h, which defines the flag constants as enums instead of preprocessor macros: % sed -n '/enum/,/^[-+]*$/p' ../SOURCES/psacct-6.3.2-large-uid.patch +enum + { + AFORK = 0x01, /* Has executed fork, but no exec. */ + ASU = 0x02, /* Used super-user privileges. */ + ACORE = 0x08, /* Dumped core. */ + AXSIG = 0x10 /* Killed by a signal. */ + }; + thus, when the below compiles % sed -n '/AFORK/,/endif/p' acct-6.3.2/lastcomm.c #ifdef AFORK if (rec->ac_flag & AFORK) putchar ('F'); else #endif there's no defined C preprocessor AFORK macro, so the code isn't compiled in Thanks for your bug report, the accounting flags should be defined as macros here, you are right. Only important issues like performance and security are fixed in RHEL 4.9 and later. This bug does not meet necessary criteria and is therefore closed. The bug does not affect RHEL 5. |