Bug 249094

Summary: virt-manager starts domU install even though error with duplicate name exists
Product: Red Hat Enterprise Linux 5 Reporter: Chuck Morrison <chuck.morrison>
Component: virt-managerAssignee: Hugh Brock <hbrock>
Status: CLOSED ERRATA QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 5.1CC: crobinso, dchapman, martine.silbermann, poelstra, rick.hester, sprabhu, xen-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHEA-2007-0637 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-11-07 16:34:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 223107    
Attachments:
Description Flags
Aggressively free domain pointer in libvirt none

Description Chuck Morrison 2007-07-20 21:06:47 UTC
Description of problem:

In making and deleting a lot of domU instances, I've occasionally used a name
more than once. Even if it was previously deleted, virt-manager always gives an
error about the name being used before. It then proceeds to start the install
even though I go back and change the name. This is confusing to say the least.

Version-Release number of selected component (if applicable):


How reproducible:

happens every time

Steps to Reproduce:
1. see above
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 2 Hugh Brock 2007-07-23 21:10:09 UTC
Hmm, good catch, thanks. This turns out to be a nasty python reference-counting
bug (we think). Working on a fix now.

Comment 3 Hugh Brock 2007-07-24 19:42:23 UTC
The patch below fixes the problem by forcing libvirt to release the underlying
pointer to the domain object, even though the python code doesn't always release
the reference reliably.

Comment 4 Hugh Brock 2007-07-24 19:45:01 UTC
Created attachment 159881 [details]
Aggressively free domain pointer in libvirt

This patch aggressively frees the domain pointer in libvirt so that when you
create a domain with the same name as one you just deleted, the deleted domain
configuration doesn't get resurrected in virt-manager.

Comment 7 Daniel Berrangé 2007-08-09 12:58:31 UTC
*** Bug 251489 has been marked as a duplicate of this bug. ***

Comment 8 Daniel Berrangé 2007-08-09 13:09:03 UTC
For reference, this bug is addressed in virt-manager-0.4.0-3.el5

* Tue Jul 24 2007 Hugh O. Brock <hbrock> - 0.4.0-3.el5
- Aggressively free libvirt domain object after it has been deleted. Workaround
  for python's unreliable garbage collection. (rhbz #249094)


Comment 11 errata-xmlrpc 2007-11-07 16:34:58 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHEA-2007-0637.html