Bug 2491010

Summary: Review Request: rust-mdbook-renderer - Library to assist implementing an mdBook renderer
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Michel Lind <michel>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: michel, package-review
Target Milestone: ---Flags: michel: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/mdbook-renderer
Whiteboard:
Fixed In Version: rust-mdbook-renderer-0.5.3-1.fc45 Doc Type: ---
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2026-06-23 18:46:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Fabio Valentini 2026-06-20 11:41:13 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-mdbook-renderer.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-mdbook-renderer-0.5.3-1.fc44.src.rpm
Upstream URL: https://crates.io/crates/mdbook-renderer

Description:
Library to assist implementing an mdBook renderer.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2026-06-20 11:41:15 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=146846474

Comment 2 Fedora Review Service 2026-06-20 11:43:13 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/10620012
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491010-rust-mdbook-renderer/fedora-rawhide-x86_64/10620012-rust-mdbook-renderer/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2026-06-20 11:49:38 UTC
rust2rpm.toml contents:

```
[package]
license-files = ["LICENSE"]

[[package.extra-sources]]
number = 2
file = "https://github.com/rust-lang/mdBook/raw/refs/tags/v0.5.3/LICENSE"
comments = ["https://github.com/rust-lang/mdBook/pull/3135"]

[scripts]
prep.post = ["cp -pav %{SOURCE2} ."]
```

successful COPR build:
https://copr.fedorainfracloud.org/coprs/decathorpe/mdbook/build/10620008/

Comment 4 Michel Lind 2026-06-23 16:10:51 UTC
LGTM

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged (spec & crates.io: 0.5.3)
✅ license matches upstream specification and is acceptable for Fedora (spec & Cargo.toml: MPL-2.0)
🫤 license file is included with %license in %files (included manually, fix submitted to upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: mdbook-renderer
  homepage: https://crates.io/crates/mdbook-renderer
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-mdbook-renderer

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fabio Valentini 2026-06-23 16:53:24 UTC
Thank you for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2026-06-23 16:56:49 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-mdbook-renderer
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 7 Fabio Valentini 2026-06-23 18:46:28 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2026-33198c0df4