Bug 2491129
| Summary: | Review Request: python-simple-term-menu - A Python package which creates simple interactive menus on the command line | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chenxiong Qi <qcxhome> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mhroncok, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/IngoMeyer441/simple-term-menu | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2497593 | ||
|
Description
Chenxiong Qi
2026-06-21 08:05:09 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/10621491 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491129-python-simple-term-menu/fedora-rawhide-x86_64/10621491-python-simple-term-menu/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/10795526 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491129-python-simple-term-menu/fedora-rawhide-x86_64/10795526-python-simple-term-menu/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. ISSUES
1. Summary ends with a dot: "A Python package which creates simple interactive menus on the command line." -- rpmlint warning summary-ended-with-dot. Remove the trailing period from Summary.
2. Description is just the same line as in summary. Consider extending it.
3. %pyproject_save_files -l is combined with explicit %license LICENSE in %files. This results in the LICENSE being shipped twice (as %license in both /usr/lib/python3.15/site-packages/simple_term_menu-1.6.6.dist-info/licenses/LICENSE and /usr/share/licenses/python3-simple-term-menu/LICENSE). Per the guidelines, -l is meant for when %license is NOT manually listed. Please keep %pyproject_save_files -l and remove the explicit %license LICENSE from %files.
4. rpmlint non-executable-script: /usr/lib/python3.15/site-packages/simple_term_menu.py has a #!/usr/bin/env python3 shebang but 644 permissions. This is an importable module, not a script (the CLI entry point is the separate /usr/bin/simple-term-menu). Please fix this upstream and possibly remove the
shebang from the installed module in %prep in the meantime, e.g. via something like: sed -i '1{/^#!/d}' simple_term_menu.py
rpmlint output
python-simple-term-menu.src: W: summary-ended-with-dot
python3-simple-term-menu.noarch: W: summary-ended-with-dot
python3-simple-term-menu.noarch: E: non-executable-script /usr/lib/python3.15/site-packages/simple_term_menu.py 644 /usr/bin/env python3
python3-simple-term-menu.noarch: W: no-manual-page-for-binary simple-term-menu
Hi Miro, thanks for your review. All the issues are addressed. PTAL. |