Bug 2491200

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10622155
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491200-python-nethsm/fedora-rawhide-x86_64/10622155-python-nethsm/fedora-review/review.txt

Found issues:

- (python3.15dist(python-dateutil) < 3~~ with python3.15dist(python-dateutil) >= 2) is deprecated, you must not depend on it.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

LGTM.

+ package name is OK
+ latest version
+ license is specified correctly (Apache 2.0)
+ license is acceptable for Fedora
+ builds and installs OK
+ R/BR/P appear correct

Standard pyproject packaging is used, nothing out of the ordinary.

> - (python3.15dist(python-dateutil) < 3~~ with python3.15dist(python-dateutil) >= 2) is deprecated, you must not depend on it.

Hmm, this is a bummer. https://fedoraproject.org/wiki/Changes/DeprecatePython-dateutil
made python-dateutil deprecated in F45. Can we replace this dependency by something else?

I can ask upstream about replacing the dateutil dependency, although it actually looks like their GitHub is starting to see activity again.

Would you like that fixed as part of this review, or could that happen in the background?

Thanks.

https://github.com/Nitrokey/nethsm-sdk-py/pull/159 is my attempt at getting rid of the dep.

> Would you like that fixed as part of this review, or could that happen in the background?

Our rules say that new dependencies on deprecated packages must not be added [1].
I saw the new activity, but I think it's better to drop the dep anyway. The activity
seems a bit weak, e.g. there is still no security policy contact info. 

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/#_consequences_of_a_package_being_deprecated

I didn't finish the paragraph:
Even if dateutil upstream is starting to be maintained again, the Fedora Change
that deprecates it has passed, so we would need to drop that first, before adding
the dependency.

That makes sense, and thank you for writing the patch! Agreed that it's the better path forwards.

I've pulled that into the spec file.

Spec URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/python3-pynitrokey/srpm-builds/10622430/python-nethsm.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/thebeanogamer/python3-pynitrokey/srpm-builds/10622430/python-nethsm-2.1.1-1.src.rpm

Created attachment 2146165 [details]
The .spec file difference from Copr build 10622155 to 10622432

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10622432
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2491200-python-nethsm/fedora-rawhide-x86_64/10622432-python-nethsm/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

With the patch, everything seems kosher. Package is APPROVED.

(I think it'd be wait for the upstream to reply to the patch before building
this officially in Fedora, at least a few days. I hope the patch is OK, but
I'm not familiar with that codebase so a review would be good.)

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-nethsm
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

FEDORA-2026-fb00edeb30 (python-nethsm-2.1.1-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-fb00edeb30

FEDORA-2026-fb00edeb30 (python-nethsm-2.1.1-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2026-12bb1ba40a (python-nethsm-2.1.1-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-12bb1ba40a

FEDORA-2026-9a8c4d6a6c (python-nethsm-2.1.1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-9a8c4d6a6c

FEDORA-2026-12bb1ba40a has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-12bb1ba40a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-12bb1ba40a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2026-9a8c4d6a6c has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-9a8c4d6a6c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-9a8c4d6a6c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2026-9a8c4d6a6c (python-nethsm-2.1.1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2026-12bb1ba40a (python-nethsm-2.1.1-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.