Bug 249214

Summary: Review Request: alienblaster - Action-loaded 2D arcade shooter game
Product: [Fedora] Fedora Reporter: Hans de Goede <hdegoede>
Component: Package ReviewAssignee: Tom "spot" Callaway <tcallawa>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: tcallawa: fedora-review+
wtogami: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-07-23 21:01:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Hans de Goede 2007-07-22 19:51:13 UTC
Spec URL: http://people.atrpms.net/~hdegoede/alienblaster.spec
SRPM URL: http://people.atrpms.net/~hdegoede/alienblaster-1.1.0-1.fc8.src.rpm
Description:
Alien Blaster is an action-loaded 2D arcade shooter game. Your mission in the
game is simple: stop the invasion of the aliens by blasting them.
Simultaneous two-player mode is available.

Comment 1 Tom "spot" Callaway 2007-07-22 21:26:29 UTC
NO DEVEL
=========

Good:

- rpmlint checks return: nothing
- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv2) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime 

APPROVED. You're getting rather good at this, Hans. :)

Comment 2 Tom "spot" Callaway 2007-07-22 21:41:47 UTC
One minor note:

The .sh script you're using to launch the alienblaster.bin has a minor bug
(preventing the game from launching).

Your script make a symlink to "sounds" instead of the correct "sound".

You should fix that before building.

Comment 3 Hans de Goede 2007-07-23 07:15:50 UTC
(In reply to comment #2)
> One minor note:
> 
> The .sh script you're using to launch the alienblaster.bin has a minor bug
> (preventing the game from launching).
> 
> Your script make a symlink to "sounds" instead of the correct "sound".
> 

Oopsee, good catch. I noticed this myself too, fixed the symlink in my ~
manually, play tested and then forgot all about it :)

And many thanks for the review!


Comment 4 Hans de Goede 2007-07-23 07:47:24 UTC
New Package CVS Request
=======================
Package Name:      alienblaster
Short Description: Action-loaded 2D arcade shooter game
Owners:            j.w.r.degoede
Branches:          FC-6 F-7 devel
InitialCC:         <empty>




Comment 5 Hans de Goede 2007-07-23 21:01:01 UTC
imported, build and submitted as F-7 update, closing.