Bug 249254

I am running a LiveCD of the initial 2007-05-31 release of Fedora 7.

I plug my Vantec NexStar 3 2.5" hard drive enclosure via a USB cable into my
Intel DQ965GF motherboard.  The drive has a single primary partition which is
formatted ext3.  I expect to see the drive icon show up on my desktop, but it
does not.

/var/log/messages shows:
kernel: usb 7-1: new high speed USB device using ehci_hcd and address 4
kernel: usb 7-1: configuration #1 chosen from 1 choice
kernel: scsi10 : SCSI emulation for USB Mass Storage devices
kernel: scsi 10:0:0:0: Direct-Access     ST910021         3MH0L3LA      PQ: 0
ANSI: 2 CCS
kernel: SCSI device sde: 195371568 512-byte hdwr sectors (100030 MB)
kernel: sde: Write Protect is off
kernel: sde: assuming drive cache: write through
kernel: SCSI device sde: 195371568 512-byte hdwr sectors (100030 MB)
kernel: sde: Write Protect is off
kernel: sde: assuming drive cache: write through
kernel:  sde: sde1
kernel: sd 10:0:0:0: Attached scsi disk sde
kernel: sd 10:0:0:0: Attached scsi generic sg0 type 0

gnome-mount says 'Device has /dev/sde1 volume.ignore set to TRUE. Refusing to
mount.'

I believe volume.ignore is set TRUE by
/usr/share/hal/fdi/policy/10osvendor/99-redhat-storage-policy-fixed-drives.fdi
because hal-device shows @block.storage_device:storage.hotpluggable = false.

The question then is, why is the USB drive I just hotplugged in not shown as
hotpluggable?

Looking at
http://webcvs.freedesktop.org/hal/hal/hald/linux2/blockdev.c?revision=1.43&view=markup
the hotplug_event_begin_add_blockdev function has a section for 'storage
devices' which appears to walk up the device chain and set is_hotpluggable =
TRUE for devices with an "info.bus" of "usb".

Looking at the output of hal-device, it shows my drive as having storage.bus =
'scsi', rather than 'usb'.  Looking at the relevant output we see:

0: udi =
'/org/freedesktop/Hal/devices/volume_uuid_adea38af_1d06_408d_9538_bee14f7bd3e4'
  info.product = 'chdata'  (string)
  info.parent =
'/org/freedesktop/Hal/devices/storage_serial_ST910021_3MH0L3LA_22223720636A' 
(string)

1: udi =
'/org/freedesktop/Hal/devices/storage_serial_ST910021_3MH0L3LA_22223720636A'
  info.product = '        3MH0L3LA'  (string)
  info.parent =
'/org/freedesktop/Hal/devices/usb_device_152d_2338_22223720636A_scsi_host_scsi_device_lun0'
 (string)

2: udi =
'/org/freedesktop/Hal/devices/usb_device_152d_2338_22223720636A_scsi_host_scsi_device_lun0'
  info.bus = 'scsi'  (string)
  info.product = 'SCSI Device'  (string)
  info.parent =
'/org/freedesktop/Hal/devices/usb_device_152d_2338_22223720636A_scsi_host'  (string)

3: udi = '/org/freedesktop/Hal/devices/usb_device_152d_2338_22223720636A_scsi_host'
  info.product = 'SCSI Host Adapter'  (string)
  info.parent = '/org/freedesktop/Hal/devices/usb_device_152d_2338_22223720636A'
 (string)

6: udi = '/org/freedesktop/Hal/devices/usb_device_152d_2338_22223720636A'
  info.product = 'USB to ATA/ATAPI Bridge'  (string)
  info.parent = '/org/freedesktop/Hal/devices/usb_device_0_0_0000_00_1d_7'  (string)
  info.vendor = 'JMicron'  (string)
  info.bus = 'usb_device'  (string)

76: udi = '/org/freedesktop/Hal/devices/usb_device_0_0_0000_00_1d_7'
  info.product = 'EHCI Host Controller'  (string)
  info.parent = '/org/freedesktop/Hal/devices/pci_8086_2836'  (string)
  info.bus = 'usb_device'  (string)

77: udi = '/org/freedesktop/Hal/devices/pci_8086_2836'
  info.bus = 'pci'  (string)
  info.product = '82801H (ICH8 Family) USB2 EHCI Controller #1'  (string)
  info.parent = '/org/freedesktop/Hal/devices/computer'  (string)

This shows that there is no device in the chain with an "info.bus" value of
"usb", only of "usb-device", thus the bottom "scsi" bus remains in effect, and
the device is not set as hotpluggable.

I don't know if this is a bug in the driver of the JMicron USB controller, or
should HAL handle the "usb-device" case as it walks the device chain?  I will
file against HAL, sorry if that's incorrect, and feel free to reassign.

Thanks.