Bug 2493314
| Summary: | Review Request: libxs - Portable C library for numerics, memory operations, and utilities | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | UW_Linux <uwsy1059> | ||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | fedora, package-review, uwsy1059 | ||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| URL: | https://github.com/hfp/libxs/releases/tag/1.0.0 | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | --- | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | Type: | --- | |||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 177841 | ||||||
| Attachments: |
|
||||||
|
Description
UW_Linux
2026-06-26 00:30:34 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://github.com/hfp/libxs/blob/main/scripts/fedora/libxs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/hfp-libxs-main/srpm-builds/10651320/libxs-1.0.0-1.20260625235357766098.main.0.g2132ebbc6.src.rpm Spec URL: https://download.copr.fedorainfracloud.org/results/packit/hfp-libxs-main/srpm-builds/10651320/libxs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/hfp-libxs-main/srpm-builds/10651320/libxs-1.0.0-1.20260625235357766098.main.0.g2132ebbc6.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/10651384 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493314-libxs/fedora-rawhide-x86_64/10651384-libxs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/10651386 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493314-libxs/fedora-rawhide-x86_64/10651386-libxs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/10651387 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493314-libxs/fedora-rawhide-x86_64/10651387-libxs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > %global debug_package %{nil} Nuh-uh. We want debuginfo in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/ > Version: 1.0.0 > Release: 1.20260625235357766098.main.0.g2132ebbc6%{?dist} Snapshot info should be part of Version, not Release. Also, you don't need to make it so detailed. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > Source0: libxs-1.0.0.tar.gz This should, preferably, be a downloadable URL. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Since the project is hosted on GitHub, you can use the following: %global git_commit COMMIT_HASH_HERE Source0: https://github.com/hfp/libxs/archive/%{git_commit}/libxs-%{git_commit}.tar.gz Or, alternatively, you can use the Forge macros: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_example > %files > %{_libdir}/libxs.so.* You should avoid using a catch-all wildcard here, as it will hide any SONAME changes. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files > %files devel > %license LICENSE.md As the devel package requires the main package, you don't need to package the licence here. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#subpackage-licensing Thank you, I will adjust the SPEC file in GitHub repo. The release strings are auto-generated by Packit, not manually designed. Spec URL: https://github.com/hfp/libxs/blob/c2c593a60fdb1965ef75879736e8cbd048a7068b/scripts/fedora/libxs.spec SRPM URL: https://github.com/hfp/libxs/releases/download/1.0.0/libxs-1.0.0-1.fc44.src.rpm [fedora-review-service-build] [fedora-review-service-build] Created attachment 2147074 [details]
The .spec file difference from Copr build 10651387 to 10660768
Copr build: https://copr.fedorainfracloud.org/coprs/build/10660768 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493314-libxs/fedora-rawhide-x86_64/10660768-libxs/fedora-review/review.txt Found issues: - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/libxs/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://github.com/hfp/libxs/blob/c2c593a60fdb1965ef75879736e8cbd048a7068b/scripts/fedora/libxs.spec SRPM URL: https://github.com/hfp/libxs/releases/download/1.0.0/libxs-1.0.0-1.fc44.src.rpm [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/10666298 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2493314-libxs/fedora-rawhide-x86_64/10666298-libxs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Gentle ping :) |