Bug 249524
| Summary: | Review Request: wxdfast - Multi-threaded download manager | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adel Gadllah <adel.gadllah> | ||||||
| Component: | Package Review | Assignee: | Dan Horák <dan> | ||||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora-package-review, notting | ||||||
| Target Milestone: | --- | Flags: | dan:
fedora-review+
kevin: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2007-09-09 09:06:15 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Adel Gadllah
2007-07-25 12:16:28 UTC
some notes from testing before formal review: - update license tag GPL => GPLv2, icons are using Creative Commons Public License - in %build - using %configure is enough, no need to set prefix, ..., no need to explicitly set CXXFLAGS for make - remove execute bit from source files (find + xargs chmod a-x) - debug package does not contain the sources (tested in mock for Rawhide/i386 and natively on FC6/x86_64) Sorry, overwriting the CXXFLAGS is necessary. Only in the top-level makefile they are OK. The debug package is created correctly too. But I have a solution that can be posted upstream, see attachments. Created attachment 162036 [details]
patch for Makefile.*
Created attachment 162037 [details]
spec file patch
hi thx for the patches I applied them, new package here: http://tgmweb.at/gadllah/wxdfast.spec http://tgmweb.at/gadllah/wxdfast-0.6.0-2.fc7.src.rpm there is a typo in the spec file when doing chmod a-x - there is \*.cpp twice Fixed package is here: http://tgmweb.at/gadllah/wxdfast.spec http://tgmweb.at/gadllah/wxdfast-0.6.0-3.fc7.src.rpm also some .h files needed fixing added that too. the review is here: OK source files match upstream: 09f8a13c399e6e8f40e9b0a2776acd4133f0f1f6 wxdfast_0.6.0.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible. License text included in package. OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Development/i386). OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane: OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app and correctly install its desktop file this package is APPROVED PS: are you aware of the many unresolved bugs in the project's sf.net bugtracker? > this package is APPROVED ok, thx for the review. > PS: are you aware of the many unresolved bugs in the project's sf.net bugtracker? no was working quite good for me (no issues yet) but thx will look at them. New Package CVS Request ======================= Package Name: wxdfast Short Description: Multi-threaded download manager Owners: drago01 Branches: FC-6 F7 devel InitialCC: Cvsextras Commits: no cvs done. you should close this bug, as the package is already built sorry was waiting for the update push to be able to build it for fc6 then I forgot to close the bug. |