Bug 249557

Summary: bring consistency to intr mount option for all nfs flavors
Product: [Fedora] Fedora Reporter: Jeff Layton <jlayton>
Component: nfs-utilsAssignee: Jeff Layton <jlayton>
Status: CLOSED UPSTREAM QA Contact: Ben Levenson <benl>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: staubach, steved
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-08-14 07:06:00 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Description Flags
upstream patch -- make mount default to nointr
patch -- make intr the default for v2/3 and fix manpage
patch -- make string-based mount options default to "intr" none

Description Jeff Layton 2007-07-25 10:55:10 EDT
util-linux defaults to setting the "intr" option for NFSv4 mounts. It should
default to "nointr".

This looks like it might also be an issue with later RHEL/Fedora releases and
upstream, but I need to confirm.
Comment 1 Jeff Layton 2007-07-25 11:05:31 EDT
Created attachment 159934 [details]
upstream patch -- make mount default to nointr

Patch I plan to send upstream once I test it. It should make mount.nfs4 default
to "nointr".
Comment 9 Jeff Layton 2007-07-25 15:17:08 EDT
Fixing tagline. I'm morphing this ticket to track some patches that I've sent
upstream to (hopefully) make intr the default for all NFS flavors...
Comment 10 Jeff Layton 2007-07-25 15:18:40 EDT
Created attachment 159973 [details]
patch -- make intr the default for v2/3 and fix manpage

This patch I sent upstream. It makes "intr" the default for v2/3 and fixes the
manpage accordingly.
Comment 11 Jeff Layton 2007-07-25 15:19:42 EDT
Created attachment 159974 [details]
patch -- make string-based mount options default to "intr"

This patch makes "intr" the default when using string-based mount options on
the latest upstream kernels.
Comment 12 Jeff Layton 2007-07-30 09:09:07 EDT
Upstream comments seem to indicate that defaulting to "intr" might be
problematic. If a close call is interrupted during the sync, then the close can
return EINTR without actually syncing the file out to the server. The file is
still closed, however and locks are released. This can lead to data corruption.
There was a bit of discussion around ways to avoid this, but for the time being
"nointr" should probably be the default.

It looks like the string-based mount options already are going to default to
nointr for nfs4. The question here is whether we want to fix struct based mount
options to do the same. Since that will hopefully just go away eventually, it
may be best to just not worry about it.
Comment 13 Jeff Layton 2007-08-14 07:06:00 EDT
Chuck Lever's doing a number of mount.nfs cleanups upstream and seems to be
looking at this as well. I'll leave this in his hands for now. It's unlikely
that we'd want to change RHEL's behavior anyway...