Bug 2497530

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10690465
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497530-perl-starlet/fedora-rawhide-x86_64/10690465-perl-Starlet/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires:
FIX: Add 'perl(Module::Install::Metadata)' and 'perl(Module::Install::WriteAll)'
     to BuildRequires - they provide 'all_from', 'requires', 'test_requires'
     and 'WriteAll' used in Makefile.PL and the bundled inc/ is removed in %prep.
FIX: Add 'perl(IO::Socket::UNIX)' to BuildRequires (test dependency
     used in t/10unix_domain_socket.t).
FIX: Remove duplicate 'perl(IO::Socket::INET)' from test requirements
     section - it is already listed in the runtime requirements section.

$ rpm -qp --requires perl-Starlet-0.32-2.fc45.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Fcntl)
      1 perl(File::Temp)
      1 perl(HTTP::Date)
      1 perl(HTTP::Status)
      1 perl(IO::Socket::INET)
      1 perl-libs
      1 perl(List::Util)
      1 perl(Parallel::Prefork)
      1 perl(Plack)
      1 perl(Plack::HTTPParser)
      1 perl(Plack::TempBuffer)
      1 perl(Plack::Util)
      1 perl(POSIX)
      1 perl(Server::Starter)
      1 perl(Socket)
      1 perl(Starlet::Server)
      1 perl(strict)
      1 perl(Time::HiRes)
      1 perl(Try::Tiny)
      1 perl(:VERSION) >= 5.8.0
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Starlet-0.32-2.fc45.noarch.rpm | sort | uniq -c
      1 perl(Plack::Handler::Starlet)
      1 perl(Starlet) = 0.32
      1 perl-Starlet = 0.32-2.fc45
      1 perl(Starlet::Server)
Binary provides are Ok.

$ rpmlint ./perl-Starlet*
perl-Starlet.noarch: E: spelling-error ('prefork', '%description -l en_US')
perl-Starlet.src: E: spelling-error ('prefork', '%description -l en_US')
 2 packages and 1 specfiles checked; 2 errors, 0 warnings, 8 filtered, 2 badness; has taken 0.3 s
Note: The spelling errors are false positives - prefork is a technical term.
Rpmlint is ok.

Please correct all 'FIX' items.

Resolution:
Approved

(In reply to Jitka Plesnikova from comment #2)
>
> FIX: Add 'perl(Module::Install::Metadata)' and
> 'perl(Module::Install::WriteAll)'
>      to BuildRequires - they provide 'all_from', 'requires', 'test_requires'
>      and 'WriteAll' used in Makefile.PL and the bundled inc/ is removed in
> %prep.

Done.

> FIX: Add 'perl(IO::Socket::UNIX)' to BuildRequires (test dependency
>      used in t/10unix_domain_socket.t).
> FIX: Remove duplicate 'perl(IO::Socket::INET)' from test requirements
>      section - it is already listed in the runtime requirements section.

I have replaced the latter with the former.

> Resolution:
> Approved

Thank you for the review, Jikta.
The package has been unretired, the rereviewed version has been imported and built.