Bug 2497713
| Summary: | Review Request: perl-Cache-Simple-TimedExpiry - A lightweight cache with timed expiration | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Cache-Simple-TimedExpiry-0.27-52.fc45 | Doc Type: | --- |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-07-08 06:18:53 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2495870 | ||
|
Description
Jitka Plesnikova
2026-07-07 13:33:23 UTC
URL and Source0 addresses are usable. Ok.
Source0 archive (SHA-512: 80317eab341d307ad9d0fd76a92726a2d963deb9a5397ceb1a1383f0f8c5ca07e8553307d15f5a23f0c1b0a2765c1bba83bf1cdfc963e9e3271399c2d12cd79f) is original. Ok.
Summary is Ok.
Description is Ok.
License verified from Makefile.PL. Ok.
No XS code, noarch BuildArch is Ok.
TODO: Remove the find command (perl-Cache-Simple-TimedExpiry.spec:42), current ExtUtils::MakeMaker does not create empty directories.
All tests pass. Ok.
$ rpmlint perl-Cache-Simple-TimedExpiry.spec ../SRPMS/perl-Cache-Simple-TimedExpiry-0.27-52.fc45.src.rpm ../RPMS/noarch/perl-Cache-Simple-TimedExpiry-0.27-52.fc45.noarch.rpm ======================================== rpmlint session starts =======================================
rpmlint: 2.9.0
configuration:
/usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
perl-Cache-Simple-TimedExpiry.spec:1: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 1)
perl-Cache-Simple-TimedExpiry.spec:1: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 1)
=== 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
FIX: Normalize the white spaces in the spec file.
$ rpm -q -lv -p ../RPMS/noarch/perl-Cache-Simple-TimedExpiry-0.27-52.fc45.noarch.rpm drwxr-xr-x 2 root root 0 Jul 7 02:00 /usr/share/doc/perl-Cache-Simple-TimedExpiry
-rw-r--r-- 1 root root 595 Nov 20 2006 /usr/share/doc/perl-Cache-Simple-TimedExpiry/Changes
-rw-r--r-- 1 root root 1473 Jul 7 02:00 /usr/share/man/man3/Cache::Simple::TimedExpiry.3pm.gz
drwxr-xr-x 2 root root 0 Jul 7 02:00 /usr/share/perl5/vendor_perl/Cache
drwxr-xr-x 2 root root 0 Jul 7 02:00 /usr/share/perl5/vendor_perl/Cache/Simple
-rw-r--r-- 1 root root 2987 Nov 20 2006 /usr/share/perl5/vendor_perl/Cache/Simple/TimedExpiry.pm
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-Cache-Simple-TimedExpiry-0.27-52.fc45.noarch.rpm | sort -f | uniq -c
1 perl(Data::Dumper)
1 perl(strict)
1 perl(vars)
1 perl(warnings)
1 perl-libs
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Cache-Simple-TimedExpiry-0.27-52.fc45.noarch.rpm | sort -f | uniq -c
1 perl(Cache::Simple::TimedExpiry) = 0.27
1 perl-Cache-Simple-TimedExpiry = 0.27-52.fc45
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Cache-Simple-TimedExpiry-0.27-52.fc45.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=147519161). Ok.
Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Please correct the FIX item and consider fixing the TODO item before building this package.
The package is APPROVED.
Unretire request https://forge.fedoraproject.org/releng/tickets/issues/13415 Thanks for the review. |