Bug 2497962
|
Description
scka7t
2026-07-08 03:13:46 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/10695422 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10695422-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://github.com/SkyWalkerAMD/sckoc/blob/main/fedora/sckoc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/skywalkeramd/sckoc/srpm-builds/10695397/sckoc-2.0.0-1.el9.src.rpm Description: sckoc is a read-only hardware monitor for Intel and AMD servers and workstations, derived from the rdmsr utility in intel/msr-tools. It reports per-socket and per-core voltage, temperature, frequency (core, mesh, IOD and DRAM), power (RAPL, PL1/PL2, PPT), C-state residency and platform security state. Being read-only it works under Secure Boot and kernel lockdown (integrity). Fedora Account System username: skywalkeramd This is my first package and I am seeking a sponsor. The package builds successfully on fedora-43 and fedora-44 in COPR: https://copr.fedorainfracloud.org/coprs/skywalkeramd/sckoc/build/10695397/ Upstream: https://github.com/SkyWalkerAMD/sckoc License: GPL-2.0-only Reproducible: Always Spec URL: https://github.com/SkyWalkerAMD/sckoc/blob/main/fedora/sckoc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/skywalkeramd/sckoc/srpm-builds/10695397/sckoc-2.0.0-1.el9.src.rpm Description: sckoc is a read-only hardware monitor for Intel and AMD servers and workstations, derived from the rdmsr utility in intel/msr-tools. It reports per-socket and per-core voltage, temperature, frequency (core, mesh, IOD and DRAM), power (RAPL, PL1/PL2, PPT), C-state residency and platform security state. Being read-only it works under Secure Boot and kernel lockdown (integrity). Fedora Account System username: skywalkeramd This is my first package and I am seeking a sponsor. The package builds successfully on fedora-43 and fedora-44 in COPR: https://copr.fedorainfracloud.org/coprs/skywalkeramd/sckoc/build/10695795/ Upstream: https://github.com/SkyWalkerAMD/sckoc License: GPL-2.0-only Reproducible: Always (In reply to scka7t from comment #2) > Spec URL: > https://github.com/SkyWalkerAMD/sckoc/blob/main/fedora/sckoc.spec > SRPM URL: > https://download.copr.fedorainfracloud.org/results/skywalkeramd/sckoc/srpm- > builds/10695397/sckoc-2.0.0-1.el9.src.rpm > Description: > sckoc is a read-only hardware monitor for Intel and AMD servers and > workstations, derived from the rdmsr utility in intel/msr-tools. It reports > per-socket and per-core voltage, temperature, frequency (core, mesh, IOD and > DRAM), power (RAPL, PL1/PL2, PPT), C-state residency and platform security > state. Being read-only it works under Secure Boot and kernel lockdown > (integrity). > > Fedora Account System username: skywalkeramd > > This is my first package and I am seeking a sponsor. > > The package builds successfully on fedora-43 and fedora-44 in COPR: > https://copr.fedorainfracloud.org/coprs/skywalkeramd/sckoc/build/10695795/ > > Upstream: https://github.com/SkyWalkerAMD/sckoc > License: GPL-2.0-only > > Reproducible: Always Spec URL: https://github.com/SkyWalkerAMD/sckoc/blob/main/fedora/sckoc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/skywalkeramd/sckoc/srpm-builds/10695397/sckoc-2.0.0-1.el9.src.rpm Description: sckoc is a read-only hardware monitor for Intel and AMD servers and workstations, derived from the rdmsr utility in intel/msr-tools. It reports per-socket and per-core voltage, temperature, frequency (core, mesh, IOD and DRAM), power (RAPL, PL1/PL2, PPT), C-state residency and platform security state. Being read-only it works under Secure Boot and kernel lockdown (integrity). Fedora Account System username: skywalkeramd This is my first package and I am seeking a sponsor. The package builds successfully on fedora-43 and fedora-44 in COPR: https://copr.fedorainfracloud.org/coprs/skywalkeramd/sckoc/build/10695795/ Upstream: https://github.com/SkyWalkerAMD/sckoc License: GPL-2.0-only Reproducible: Always Copr build: https://copr.fedorainfracloud.org/coprs/build/10695893 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10695893-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/10695897 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10695897-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Copr build: https://copr.fedorainfracloud.org/coprs/build/10695902 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10695902-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated for 2.0.0 with a Fedora-built SRPM and a corrected description. Spec URL: https://raw.githubusercontent.com/SkyWalkerAMD/sckoc/main/fedora/sckoc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/skywalkeramd/sckoc/srpm-builds/10695972/sckoc-2.0.0-1.src.rpm Corrected description (the package is now 100% original code): sckoc is a read-only hardware monitor for Intel and AMD servers and workstations. It reports per-socket and per-core voltage, temperature, frequency (core, mesh, IOD and DRAM), power (RAPL, PL1/PL2, PPT), C-state residency and platform security state. Being read-only it works under Secure Boot and kernel lockdown (integrity). All code is original and GPL-2.0-only; the MSR reader (readoc) is an original implementation. [fedora-review-service-build] Created attachment 2148009 [details]
The .spec file difference from Copr build 10695902 to 10695982
Copr build: https://copr.fedorainfracloud.org/coprs/build/10695982 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10695982-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.0.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.0.0/sckoc-2.0.0-1.fc44.src.rpm Changes since the previous submission: - %install was shipping the compiled `readoc` helper as %{_bindir}/sckoc, and the actual monitor script was not packaged at all. Fixed: the script is now installed as %{_bindir}/sckoc and the compiled helpers as %{_libexecdir}/sckoc/{readoc,hsmp-msg}. - Removed an inaccurate statement in %description claiming derivation from intel/msr-tools — all code in this package is original work (License: GPL-2.0-only, unchanged). - %build now uses %set_build_flags + %make_build so distribution compiler and linker flags apply to both helpers. - Added %check smoke tests (script parse check, readoc -V) that would have caught the mispackaging. - Added Requires: kmod (the script probes optional kernel modules at runtime) and co-owned the bash-completion directories. - Note: the upstream 2.0.0 tag was re-cut to include these fixes (the package has never shipped in Fedora), so the Source0 tarball checksum changed intentionally. rpmlint: 5 errors, 2 warnings. The five spelling-error hits (dev, cpu, msr, hsmp, amd) are dictionary false positives on device paths and kernel module names quoted verbatim in %description (/dev/cpu/*/msr, /dev/hsmp, amd_hsmp). The two specfile-warnings are a missing en_US.UTF-8 locale in the build container, unrelated to the spec. Created attachment 2148256 [details]
The .spec file difference from Copr build 10695982 to 10704346
Copr build: https://copr.fedorainfracloud.org/coprs/build/10704346 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10704346-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Fixed the incorrect-fsf-address rpmlint error: COPYING now carries the current canonical GPLv2 text from gnu.org (the old FSF postal address was the only change). The 2.0.0 tag was re-cut accordingly; Spec and SRPM URLs are unchanged: Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.0.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.0.0/sckoc-2.0.0-1.fc44.src.rpm The remaining rpmlint spelling-error hits (dev, cpu, msr, hsmp, amd) are dictionary false positives on device paths and kernel module names quoted verbatim in %description. A man page for sckoc(1) is planned upstream. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/10704659 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10704659-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Added a sckoc(1) man page and SPDX license identifiers to all source files, addressing the no-manual-page-for-binary warning and the licensecheck "unknown license" note from the previous review template. The 2.0.0 tag was re-cut to include these changes (the package has not shipped anywhere official yet); Spec and SRPM URLs are unchanged: Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.0.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.0.0/sckoc-2.0.0-1.fc44.src.rpm The remaining rpmlint spelling-error hits (dev, cpu, msr, hsmp, amd) are dictionary false positives on device paths and kernel module names quoted verbatim in %description. [fedora-review-service-build] Created attachment 2148267 [details]
The .spec file difference from Copr build 10704659 to 10704805
Copr build: https://copr.fedorainfracloud.org/coprs/build/10704805 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10704805-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.1.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.1.0/sckoc-2.1.0-1.fc44.src.rpm Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.1.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.1.0/sckoc-2.1.0-1.fc44.src.rpm Updated to 2.1.0. Changes since the 2.0.0 submission: read-only TPMI MMIO fallback for uncore/mesh frequency on pre-6.5 kernels (Granite Rapids+), ryzen_smu PM-table fallback on consumer Ryzen, vendor-aware HT/SMT label, expanded bash completion, uninstall hardening. Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.1.1/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.1.1/sckoc-2.1.1-1.fc44.src.rpm 2.1.1: added SPDX license identifiers to all remaining files and reworded %description to eliminate the rpmlint spell-checker false positives seen in the automated review of 2.0.0. No functional changes since 2.1.0. Created attachment 2148340 [details]
The .spec file difference from Copr build 10708246 to 10708247
Copr build: https://copr.fedorainfracloud.org/coprs/build/10708246 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10708246-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 2148341 [details]
The .spec file difference from Copr build 10708246 to 10708247
Copr build: https://copr.fedorainfracloud.org/coprs/build/10708247 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10708247-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.2.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.2.0/sckoc-2.2.0-1.fc44.src.rpm 2.2.0: new `sckoc uncore` subcommand (per-domain uncore/mesh frequency limits, including BIOS boot values where the sysfs driver exposes them), CPU identification block in the monitor, Intel per-core voltage relabeled as VID (it is the regulator request, not a measured value). The review SRPM is now built with the original GitHub tag tarball, so the Source0 checksum matches upstream exactly. Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.2.1/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.2.1/sckoc-2.2.1-1.fc44.src.rpm 2.2.1: cleanup release on top of 2.2.0 (new `sckoc uncore` subcommand, CPU identification block, Intel per-core voltage relabeled as VID). The review SRPM now embeds the original GitHub tag tarball, so the Source0 checksum matches upstream exactly. Updated to 2.3.0. Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.3.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/2.3.0/sckoc-2.3.0-1.fc44.src.rpm Changes since 2.2.1: - readoc gained a batch read protocol; the monitor now samples all counters in a handful of reads instead of one process per core per register, with a single shared sampling window - new --json output (schemas sckoc-mon-v1 and sckoc-uncore-v1) on the mon and uncore subcommands - per-core rows within 10 C of TjMax are flagged - sckoc uncore no longer needs the msr module when the intel-uncore-frequency sysfs driver is present - added a tests/ regression suite, run in CI rpmlint remains clean; the Source0 checksum now matches upstream exactly (the workflow fetches the GitHub tarball via spectool). Updated to 3.0.0 Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/3.0.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/3.0.0/sckoc-3.0.0-1.fc44.src.rpm Updated to 3.2.0 Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/3.2.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/3.2.0/sckoc-3.2.0-1.fc44.src.rpm Created attachment 2149447 [details]
The .spec file difference from Copr build 10708247 to 10758282
Copr build: https://copr.fedorainfracloud.org/coprs/build/10758282 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10758282-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated to 4.0.0 Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.0/sckoc-4.0.0-1.fc44.src.rpm Created attachment 2149453 [details]
The .spec file difference from Copr build 10758282 to 10758836
Copr build: https://copr.fedorainfracloud.org/coprs/build/10758836 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10758836-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.0/sckoc-4.0.0-1.fc44.src.rpm Created attachment 2152229 [details]
The .spec file difference from Copr build 10758836 to 10760404
Copr build: https://copr.fedorainfracloud.org/coprs/build/10760404 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10760404-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Updated to 4.0.1 Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.1/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.1/sckoc-4.0.0-1.fc44.src.rpm [fedora-review-service-build] Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.1/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.1/sckoc-4.0.0-1.fc44.src.rpm There seems to be some problem with the following file. SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.1/sckoc-4.0.0-1.fc44.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.1/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.0.1/sckoc-4.0.1-1.fc44.src.rpm Created attachment 2152232 [details]
The .spec file difference from Copr build 10760404 to 10760828
Copr build: https://copr.fedorainfracloud.org/coprs/build/10760828 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2497962-sckoc/fedora-rawhide-x86_64/10760828-sckoc/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. [fedora-review-service-build] Spec URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.1.0/sckoc.spec SRPM URL: https://github.com/SkyWalkerAMD/sckoc/releases/download/4.1.0/sckoc-4.1.0-1.fc44.src.rpm BTW both files are now inaccessible. |