Bug 2498484
| Summary: | Review Request: rust-linktime-proc-macro - Proc-macro helpers for linktime crates (ctors, dtors, linker sections) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | decathorpe:
fedora-review+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://crates.io/crates/linktime-proc-macro | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-07-24 11:29:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2452357 | ||
|
Description
Michel Lind
2026-07-09 12:30:18 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/10704320 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2498484-rust-linktime-proc-macro/fedora-rawhide-x86_64/10704320-rust-linktime-proc-macro/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > most doctest assertions failing and there are no lib tests This is not entirely true. 2 out of 18 doctests fail, I wouldn't say that's "most". The failures look related to the directory layout being different in the published crate than in the upstream workspace, so the failures *do* look harmless, though. I won't block the review on that though. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional) Ack, thanks, I'll try and enable the remaining doctests; at the very least I'll reword that incorrect assertion. If only it's trivial to disable specific doctests... The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-linktime-proc-macro Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` FEDORA-2026-b85a76049e (rust-linktime-proc-macro-0.2.0-2.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-b85a76049e FEDORA-2026-b85a76049e (rust-linktime-proc-macro-0.2.0-2.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2026-4ad3a2ce36 (rust-link-section-0.19.0-1.fc44, rust-linktime-proc-macro-0.2.0-2.fc44, and 1 more) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-4ad3a2ce36 FEDORA-2026-1962ea76b4 (rust-link-section-0.19.0-1.fc43, rust-linktime-proc-macro-0.2.0-2.fc43, and 1 more) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-1962ea76b4 FEDORA-2026-4ad3a2ce36 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-4ad3a2ce36 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-4ad3a2ce36 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2026-0b9dbefa8c (rust-link-section-0.19.0-2.el10_3, rust-linktime-proc-macro-0.2.0-2.el10_3, and 1 more) has been submitted as an update to Fedora EPEL 10.3. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-0b9dbefa8c FEDORA-EPEL-2026-0b9dbefa8c has been pushed to the Fedora EPEL 10.3 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-0b9dbefa8c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-1962ea76b4 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-1962ea76b4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-1962ea76b4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-4ad3a2ce36 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-4ad3a2ce36 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-4ad3a2ce36 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2026-0b9dbefa8c has been pushed to the Fedora EPEL 10.3 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-0b9dbefa8c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2026-594b3d173b (rust-coreutils-0.7.0-10.el9, rust-ctor-1.0.8-1.el9, and 5 more) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-594b3d173b FEDORA-EPEL-2026-594b3d173b has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2026-594b3d173b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2026-1962ea76b4 (rust-link-section-0.19.0-1.fc43, rust-linktime-proc-macro-0.2.0-2.fc43, and 1 more) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2026-0b9dbefa8c (rust-coreutils-0.7.0-10.el10_3, rust-ctor-1.0.8-1.el10_3, and 7 more) has been pushed to the Fedora EPEL 10.3 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2026-4ad3a2ce36 (rust-coreutils-0.7.0-10.fc44, rust-ctor-1.0.8-1.fc44, and 7 more) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2026-594b3d173b (rust-coreutils-0.7.0-10.el9, rust-ctor-1.0.8-1.el9, and 7 more) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. |