Bug 2499893
| Summary: | Review Request: dds10-thumbnailer-kde - A KDE thumbnail creator for DDS image format | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | solomoncyj |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | NEW --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | farchord, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | https://github.com/meyraud705/dds10-thumbnailer-kde | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
solomoncyj
2026-07-14 04:25:04 UTC
Some early review notes: I believe the Version field needs to be blank here, otherwise as you can see in the naming of your srpm, it adds version information twice: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_example Upstream recommends getting qt6-core and qt6-gui. It's possible those are being brought in by something else, and those requirements are in the CMakeLists.txt, so I recommend uncommenting them as, if something in the stack changes and those are no longer automatically brought in, building would fail. Secondly, do consider using the cmake() names for the devel packages. For example: ``` #BuildRequires: qt6-core-devel #BuildRequires: qt6-gui-devel BuildRequires: kf6-kio-devel ``` Would become ``` #BuildRequires: cmake(Qt6Core) #BuildRequires: cmake(Qt6Gui) BuildRequires: cmake(KF6KIO) ``` Third, usually, if you build using the KDE stack and ECM, you do want to use %cmake_kf6 instead of %cmake. Oh also, and this is rather new, consider putting the %cmake_kf6 argument in the %conf section of the spec. That should be right between %prep and %build. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/KDEPackaging/#_available_macros Once you did all that, I suspect you won't need to use -DKDE_INSTALL_USE_QT_SYS_PATHS=ON at least. Not sure about the ninja argument. |