Bug 250340

Summary: Review Request: perl-ExtUtils-F77 - Simple interface to F77 libs
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: Package ReviewAssignee: Jason Tibbitts <j>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: j: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-08-02 15:30:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Orion Poplawski 2007-07-31 22:07:40 UTC
Spec URL: http://www.cora.nwra.com/~orion/fedora/perl-ExtUtils-F77.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/perl-ExtUtils-F77-1.16-1.src.rpm
Description:
This module tries to figure out how to link C programs with Fortran
subroutines on your system. Basically one must add a list of Fortran
runtime libraries. The problem is their location and name varies with each
OS/compiler combination!

Comment 1 Parag AN(पराग) 2007-08-01 08:28:10 UTC
mock build failed

+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/require....
ExtUtils::F77: Version 1.16
Use of uninitialized value in pattern match (m//) at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 251.
Can't exec "g77": No such file or directory at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 176.
Use of uninitialized value in scalar chomp at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 177.
Can't exec "g77": No such file or directory at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 176.
Use of uninitialized value in scalar chomp at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 177.
Can't exec "g77": No such file or directory at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 176.
Use of uninitialized value in scalar chomp at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 177.
Can't exec "g77": No such file or directory at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 176.
Use of uninitialized value in scalar chomp at
/builddir/build/BUILD/ExtUtils-F77-1.16/blib/lib/ExtUtils/F77.pm line 177.
Can't exec "f77": No such file or directory at t/require.t line 28.
FAILED test 2
        Failed 1/2 tests, 50.00% okay
Failed Test Stat Wstat Total Fail  Failed  List of Failed
-------------------------------------------------------------------------------
t/require.t                2    1  50.00%  2
Failed 1/1 test scripts, 0.00% okay. 1/2 subtests failed, 50.00% okay.
make: *** [test_dynamic] Error 255
error: Bad exit status from /var/tmp/rpm-tmp.33023 (%check)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.33023 (%check)


Comment 2 Orion Poplawski 2007-08-01 15:16:55 UTC
Whoops:

* Wed Aug  1 2007 Orion Poplawski 1.16-2
- Add BR: gcc-gfortran

http://www.cora.nwra.com/~orion/fedora/perl-ExtUtils-F77.spec
http://www.cora.nwra.com/~orion/fedora/perl-ExtUtils-F77-1.16-2.src.rpm


Comment 3 Jason Tibbitts 2007-08-01 21:56:43 UTC
Not much to say.

* source files match upstream:
   d3dfed878678495bbd1054d78ad100ddd3df59cbc8a2ce550dae9cd2e989b84c  
   ExtUtils-F77-1.16.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package (or at least the COPYING file is).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   perl(ExtUtils::F77) = 1.16
   perl-ExtUtils-F77 = 1.16-2.fc8
  =
   perl(:MODULE_COMPAT_5.8.8)
   perl(Config)
   perl(File::Spec)
* %check is present and all tests pass:
   All tests successful.
   Files=1, Tests=2,  0 wallclock secs ( 0.02 cusr +  0.03 csys =  0.05 CPU)
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 4 Orion Poplawski 2007-08-01 22:33:54 UTC
Thanks for the review!

New Package CVS Request
=======================
Package Name: perl-ExtUtils-F77
Short Description: Simple interface to F77 libs
Owners: orion.com
Branches: F-7 FC-6 EL-5 EL-4
InitialCC: 


Comment 5 Kevin Fenzi 2007-08-02 02:06:47 UTC
cvs done.

Comment 6 Orion Poplawski 2007-08-02 15:30:49 UTC
Imported and built.