Bug 2508529
| Summary: | Review Request: rust-clock-bound - feed forward clock sync daemon | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shamik <shamchak808> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <spotrh> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, spotrh |
| Target Milestone: | --- | Flags: | spotrh:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | --- | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2026-08-26 03:49:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Shamik
2026-07-29 19:21:16 UTC
A few cleanups here: 1. You should not need to hardcode a definition for the "autorelease" macro in Fedora 2. Your "john doe" %changelog should be replaced with just: %changelog %autochangelog 3. The License tag is incorrect. The actual licensing here is much more complex, see LICENSE.dependencies. We need to list the full license combination set, which is: License: ((MIT OR Apache-2.0) AND Unicode-3.0) AND Apache-2.0 AND (Apache-2.0 OR MIT) AND (Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT) AND (BSD-2-Clause OR Apache-2.0 OR MIT) AND MIT AND Unicode-3.0 Everything else looks okay here. Show me a .spec file with those issues addressed and I'll approve this package and sponsor the maintainer. Thank you for the comments. For 1 and 2, looks like my spec file got mangled when creating the src.rpm. Found a way to rebuild with the fixes. For 3, confirmed the summary output in the build log and added the output line to the License tag. Updated Spec URL: https://download.copr.fedorainfracloud.org/results/shamchak/rust-clock-bound/srpm-builds/10794873/rust-clock-bound.spec Updated SRPM URL: https://download.copr.fedorainfracloud.org/results/shamchak/rust-clock-bound/srpm-builds/10794873/rust-clock-bound-3.0.0alpha.1-1.fc44.src.rpm Updated koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=148488706 Order doesn't matter in license state, so "Apache-2.0 OR MIT" is the same as "MIT OR Apache-2.0". The tooling isn't smart enough to dedupe there, so you need to. Gotcha, Fixed! Spec URL: https://download.copr.fedorainfracloud.org/results/shamchak/rust-clock-bound/srpm-builds/10795019/rust-clock-bound.spec Looks good to me, approved. The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clock-bound Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-clock-bound Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org` FEDORA-2026-6e19f3d0df (rust-clock-bound-3.0.0~alpha.1-2.fc46) has been submitted as an update to Fedora 46. https://bodhi.fedoraproject.org/updates/FEDORA-2026-6e19f3d0df FEDORA-2026-6e19f3d0df (rust-clock-bound-3.0.0~alpha.1-2.fc46) has been pushed to the Fedora 46 stable repository. If problem still persists, please make note of it in this bug report. |