Bug 250904

BTW what correct naming should be for this package - fuse-python (as in
upstream) or python-fuse?

rpmlint says:
W: fuse-python invalid-license GPL
W: fuse-python mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 6)

Please change license to GPLv2 or GPLv2+ .
Do not mix tabs and spaces in spec file.

I think python-fuse name is better, but fuse-python is not bad too.

%{python_sitearch}/fuseparts directory is not owned by packages. Please add an
%dir %{python_sitearch}/fuseparts into spec file.

Add these files to documentation:
  examples + it's content
  README.1st
  maybe README.historic too
  and maybe PKG-INFO too, which contains many interesting information

There are more rpmlint errors on binary packages. They have been fixed in my new
packages:

* Thu Sep  6 2007 Jan ONDREJ (SAL) <ondrejj> 0.2-2
- changed permissions for sitearch files to 644
- added fuseparts dir to package
- added egg-info directory with it's content
- license changed to LGPLv2, according to documentation and sources
- added provides for python-fuse (remove it on rename)

http://www.salstar.sk/pub/fedora/SPECS/fuse-python.spec
http://www.salstar.sk/pub/fedora/SRPMS/7/fuse-python-0.2-2.fc7.src.rpm

May be it needs to be renamed to python-fuse, but I don't know it it needs a new
Review Request ticket or not.

You do not use the python_sitelib and pyver macros, therefore you should not
define them.

%{!?python_sitelib: %define python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
%{!?pyver: %define pyver %(%{__python} -c "import sys ; print sys.version[:3]")}

Done.

* Sun Sep  9 2007 Jan ONDREJ (SAL) <ondrejj> 0.2-3
- removed non used macros
- Changelog file converted to UTF-8

http://www.salstar.sk/pub/fedora/SPECS/fuse-python.spec
http://www.salstar.sk/pub/fedora/SRPMS/7/fuse-python-0.2-3.fc7.src.rpm

Hi,

Can you follow the install procedure given here:
http://fedoraproject.org/wiki/Packaging/Python/Eggs#head-3e899702195642d7d12483e0d73451b70e8d3e9c

This will allow the egg information to work in Fedora 8 and beyond.

Done.

http://peter.fedorapeople.org/fuse-python.spec
http://peter.fedorapeople.org/fuse-python-0.2-4.fc7.src.rpm

I've got some things to discuss:

* I changed %files section according to the  Packaging/Python/Eggs from Jan's
variant when all files to package were explicitly named to more simplified form
%{python_sitearch}/* - which variant is preferrable? Personally I like Jan's
idea about explicit naming of all files but in the above example they use short
version: %{python_sitearch}/*

* What macro should be used? python_sitearch or python_sitelib? What are
differences between these macros and which is prefferable? 

OK, shortest form is OK.

python_sitearch macro is for architecture dependent files. Your package contains
an *.so module for python, which is architecture dependent, this means, that it
is correctly packaged into python_sitearch.

Please use %{__python} macro.

BuildRequires:  python-devel can be dropped, because it is required by setuptools.
Tested build on fedora-devel and fedora7.

Ok, cleaned a bit.
About macros - I decided not to use them at all.

http://peter.fedorapeople.org/fuse-python.spec
http://peter.fedorapeople.org/fuse-python-0.2-5.fc7.src.rpm

OK, package APPROVED.

New Package CVS Request
=======================
Package Name: fuse-python
Short Description: Python bindings for FUSE - filesystem in userspace
Owners: peter
Branches: FC-6 F-7
Cvsextras Commits: yes

cvs done.

fuse-python-0.2-5.fc7 has been pushed to the Fedora 7 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update fuse-python'

fuse-python-0.2-5.fc7 has been pushed to the Fedora 7 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: fuse-python
New Branches: EL-5
Owners: peter

cvs done.