Bug 251317
| Summary: | Review Request: pinot - Personal search and metasearch for the Desktop | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adel Gadllah <adel.gadllah> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-08-14 08:03:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Adel Gadllah
2007-08-08 11:18:52 UTC
Rebuild fails even on rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=97891 Shoould be fixed now: http://tgmweb.at/gadllah/pinot.spec http://tgmweb.at/gadllah/pinot-0.75-2.fc7.src.rpm Note: I tried this by: koji build --scratch dist-f8 <your srpm> sry its not dbus-devel but dbus-glib-devel which is needed. here a fixed packages: http://tgmweb.at/gadllah/pinot.spec http://tgmweb.at/gadllah/pinot-0.75-3.fc7.src.rpm I am currently running a test build in mock but it havn't failed at the configure stage ;) after submitting this the build finished in mock ... so should be working now :) Only tried to rebuild and now it seems okay. http://koji.fedoraproject.org/koji/taskinfo?taskID=98210 Some notes:
* On %build section
----------------------------------------
%configure
CFLAGS=$RPM_OPT_FLAGS make
----------------------------------------
- %configure sets CFLAGS and setting CFLAGS environ
on make should not be needed.
* Directory ownership
- Please make it sure that all directory this package creates
newly are owned by this package.
Currently the following directories are not owned by
any packages.
----------------------------------------
%_libdir/pinot/
%_libdir/pinot/filters/
%_sysconfdir/pinot/
----------------------------------------
* Debuginfo source permission
- Currently rpmlint complains a lot against debuginfo rpm
like:
----------------------------------------
E: pinot-debuginfo script-without-shebang
/usr/src/debug/pinot-0.75/UI/GTK2/src/indexDialog.cc
E: pinot-debuginfo script-without-shebang
/usr/src/debug/pinot-0.75/UI/GTK2/src/WorkerThreads.cpp
----------------------------------------
This is because the original source codes have inappropritate
permission (which must be 0644).
* Executable permission v.s. shebang
-----------------------------------------
E: pinot-deskbar non-executable-script
/usr/lib/deskbar-applet/handlers/pinot-live.py 0644
-----------------------------------------
- This is because this script has shebang (#!/usr/bin/env python)
but does not have executable permission.
It looks that this script is called by some software and it is
not executed directly. So remove shebang from this script.
* scriptlets - update of gtk icon cache
- (please check "GTK+ icon cache" of
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets )
* Scriptlets are needed even for %postun.
* Please make it sure that this script ends with success
(i.e. add "|| : " or add "exit 0")
>This is because the original source codes have inappropritate
>permission (which must be 0644).
how can I fix this whitout changing the tarball itself?
chmod 0644 in %build or %install causes permisson issues.
(In reply to comment #9) > >This is because the original source codes have inappropritate > >permission (which must be 0644). > how can I fix this whitout changing the tarball itself? > chmod 0644 in %build or %install causes permisson issues. stupid mistake please ignore this comment. I uploaded a fixed srpm and spec: http://tgmweb.at/gadllah/pinot.spec http://tgmweb.at/gadllah/pinot-0.75-4.fc7.src.rpm For -4:
(I am still rebuilding -4 srpm, so just checked your spec file)
----------------------------------------------------
@@ -85,6 +108,7 @@
%{_bindir}/pinot-index
%{_bindir}/pinot-search
%{_datadir}/pinot/
+%{_libdir}/pinot/
%{_libdir}/pinot/filters/libexternalfilter.so*
%{_libdir}/pinot/filters/libmboxfilter.so*
%{_libdir}/pinot/filters/libtaglibfilter.so*
@@ -100,6 +124,7 @@
%{_datadir}/icons/hicolor/24x24/apps/pinot.png
%{_datadir}/icons/hicolor/22x22/apps/pinot.png
%{_datadir}/icons/hicolor/16x16/apps/pinot.png
+%{_sysconfdir}/pinot/
%config(noreplace) %{_sysconfdir}/pinot/external-filters.xml
%config(noreplace) %{_sysconfdir}/pinot/globalconfig.xml
%config(noreplace) %{_sysconfdir}/pinot/textcat_conf.txt
-----------------------------------------------------
- The file entry
-----------------------------------------------------
foo/
-----------------------------------------------------
(where foo is the directory) means the directory foo itself and
all files/directories/ etc.. under foo/ so this makes duplicate
file entries.
For %{_libdir}/pinot/, %{_libdir}/pinot/filters/libexternalfilter.so*
and on are now not needed.
For {_sysconfdir}/pinot/, mark this as %dir, i.e.
-------------------------------------------------
%dir %{_sysconfdir}/pinot
%config(noreplace) %{_sysconfdir}/pinot/external-filters.xml
.........
-------------------------------------------------
or just:
-------------------------------------------------
%config(noreplace) %{_sysconfdir}/pinot/
-------------------------------------------------
The latter description contains directory %_sysconfdir/pinot
and all files under the directory, and mark all files under
%_sysconfdir/pinot as %config(noreplace).
fixed the duplicate ownership: http://tgmweb.at/gadllah/pinot.spec http://tgmweb.at/gadllah/pinot-0.75-5.fc7.src.rpm Okay
One comment and one rpmlint
* desktop-file-install
--------------------------------------------------------
desktop-file-install --vendor fedora \
--dir $RPM_BUILD_ROOT%{_datadir}/applications \
$RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop
rm -f $RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop
--------------------------------------------------------
- This can be done by one line:
--------------------------------------------------------
desktop-file-install --vendor fedora \
--dir $RPM_BUILD_ROOT%{_datadir}/applications \
--delete-original \
$RPM_BUILD_ROOT%{_datadir}/applications/pinot.desktop
--------------------------------------------------------
* rpmlint
--------------------------------------------------------
W: pinot macro-in-%changelog files
--------------------------------------------------------
- In changelog, use %% (i.e. Fix %%files section)
to avoid that % macro is expanded.
Please fix the issues above before committing into Fedora CVS.
---------------------------------------------------------
This package (pinot) is APPROVED by me
---------------------------------------------------------
ok thx for the review fixed both in -6: http://tgmweb.at/gadllah/pinot.spec http://tgmweb.at/gadllah/pinot-0.75-6.fc7.src.rpm --------------------------------------------------- New Package CVS Request ======================= Package Name: pinot Short Description: Personal search and metasearch for the Desktop Owners: drago01 Branches: devel Well, now CVS Request templete has "Commits by cvsextras" line. Please re-check http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure Ok, I missed that part, added. ---------------------------------------- New Package CVS Request ======================= Package Name: pinot Short Description: Personal search and metasearch for the Desktop Owners: drago01 Branches: devel Commits by cvsextras: yes Ok, I missed that part, added. ---------------------------------------- New Package CVS Request ======================= Package Name: pinot Short Description: Personal search and metasearch for the Desktop Owners: drago01 Branches: devel Commits by cvsextras: yes cvs done. |