Bug 251419

Already submitted in bug 239968, although that one seems stalled.

(In reply to comment #1)
> Already submitted in bug 239968, although that one seems stalled.

Oops, I added a comment there pinging the submitter and trying to coordinate.

The other review turns out to be dead (just closed by the reviewer) so anyone
interested, feel free to review this.

Just tried to rebuild (on rawhide) but it failed..
http://koji.fedoraproject.org/koji/taskinfo?taskID=99778

(In reply to comment #4)
> Just tried to rebuild (on rawhide) but it failed..
> http://koji.fedoraproject.org/koji/taskinfo?taskID=99778

Hmm, so it turns out some parts use glib1 and other parts glib2, not pretty,
anyways I've just updated to a new version, because of some other issues. And
that fixes the need for glib1 too (no longer needed), here is the new version:

Spec URL: http://people.atrpms.net/~hdegoede/mdbtools.spec
SRPM URL: http://people.atrpms.net/~hdegoede/mdbtools-0.6-0.1.pre1.fc8.src.rpm

Created attachment 161187 [details]
gdb log of gmdb2

rebuild seems okay.
http://koji.fedoraproject.org/koji/taskinfo?taskID=100188

Some notes:

* Dependency for -devel subpackage
  - Check the dependency for -devel subpackage. Header files
    included in this package contains some "#include" macros,
    which require some additional development rpms.
    (maybe pkgconfig .pc files also need to be fixed)

* GUI program causes SEGV
  - /usr/bin/gmdb2 causes SEGV when File->Properties is selected
    (gdb log attached)

(In reply to comment #6)
> Created an attachment (id=161187) [edit]
> gdb log of gmdb2
> 
> rebuild seems okay.
> http://koji.fedoraproject.org/koji/taskinfo?taskID=100188
> 
> Some notes:
> 
> * Dependency for -devel subpackage
>   - Check the dependency for -devel subpackage. Header files
>     included in this package contains some "#include" macros,
>     which require some additional development rpms.
>     (maybe pkgconfig .pc files also need to be fixed)
> 

Hmm, it installed headers used for building the tools too, fixed. Added
glib2-devel Requires as that one gets used by the lib headers too. The .pc files
were/are fine.

> * GUI program causes SEGV
>   - /usr/bin/gmdb2 causes SEGV when File->Properties is selected
>     (gdb log attached)

Ah it allows you to press properties without having a file open, fixed.

New version:
* Mon Aug 13 2007 Hans de Goede <j.w.r.degoede> 0.6-0.2.pre1
- Stop gmdb from crashing when selecting file->properties without having a file
  loaded (bz 251419)
- Don't install headers used to build tools (install only those of libmdb)
- Add glib2-devel to the -devel Requires

Spec URL: http://people.atrpms.net/~hdegoede/mdbtools.spec
SRPM URL: http://people.atrpms.net/~hdegoede/mdbtools-0.6-0.2.pre1.fc8.src.rpm

Created attachment 161254 [details]
(another) gdb log of gmdb2

Almost okay, except that I found another crash..

When I clicked cross button, gdmb2 SEGVs.
gdm log attached (this is due to gtk2 side bug?)

(In reply to comment #8)
> Almost okay, except that I found another crash..
> 
> When I clicked cross button, gdmb2 SEGVs.
> gdm log attached (this is due to gtk2 side bug?) 

Alsmost the same issue as with the properties, this is fixed now too:

Spec URL: http://people.atrpms.net/~hdegoede/mdbtools.spec
SRPM URL: http://people.atrpms.net/~hdegoede/mdbtools-0.6-0.2.pre1.fc8.src.rpm

Oops, the fixed srpm should be:
SRPM URL: http://people.atrpms.net/~hdegoede/mdbtools-0.6-0.3.pre1.fc8.src.rpm

(I have not rebuilt and installed -0.3 yet)

One question:
While rpm name has "pre1", there is a patch for pre1 -> cvs20051109
and so this is essentially the version "cvs 2005-11-09", not "pre1"?

(In reply to comment #11)
> (I have not rebuilt and installed -0.3 yet)
> 
> One question:
> While rpm name has "pre1", there is a patch for pre1 -> cvs20051109
> and so this is essentially the version "cvs 2005-11-09", not "pre1"?

True, especially considering the large amount of changes in the cvs patch. I'll
change the release field to 0.x.cvs20051109 with the next iteration.

Okay.

* Build okay
  http://koji.fedoraproject.org/koji/taskinfo?taskID=103010
* Spec file okay
* Seems to work well

------------------------------------------------
    This package (mdbtools) is APPROVED by me
------------------------------------------------

New Package CVS Request
=======================
Package Name:      mdbtools
Short Description: Access data stored in Microsoft Access databases
Owners:            jwrdegoede / j.w.r.degoede
Branches:          FC-6 F-7 devel
InitialCC:         <empty>
Commits by cvsextras: yes

cvs done.

Thanks for the review!

Imported and build, closing.