Bug 251680
Summary: | Review Request: amtterm - Serial-over-lan (sol) client for Intel AMT | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gerd Hoffmann <kraxel> |
Component: | Package Review | Assignee: | David Lutterkort <lutter> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, hbrock, notting |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | Flags: | lutter:
fedora-review+
wtogami: fedora-cvs+ |
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-08-23 12:19:38 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Gerd Hoffmann
2007-08-10 11:57:36 UTC
Updated to version 0.2. SRPM: http://kraxel.fedorapeople.org/amtterm/amtterm-0.2-1.fc7.src.rpm Spec: same as above. Updated to version 0.3. Review (based on 0.4 srpm/spec): OK - Naming, versioning, sources identical with upstream OK - Package builds in rawhide/fc7/fc6 buildroot OK - spec file is sane FIX - License tag is ok, but there's no license text anywhere. At the least, include an appropriate copy of the GPLv2 as %doc; even better if the source files have a header that gives the license/copyright, too. (In general, we defer to upstream on these issues, but since you are upstream, it would be good to fix that) FIX - rpmlint complains about missing 'rm -rf %{buildroot}' in %install FIX - Source should point to full URL for downloading the source tarball, i.e. http://dl.bytesex.org/releases/%{name}/%{name}-%{version}.tar.gz FIX - Remove the 'Autoreqprov' line from the specfile; AFAIK, not needed for Fedora Apart from these cosmetic fixes, looks good. New release 0.5 and new package uploaded to http://kraxel.fedorapeople.org/amtterm/ APPROVED. One minor misunderstanding: the 'Source' tag in the specfile should have the full URL to the source tarball (what's in the 'URL' tag right now). The 'URL' field generally should point to a project page or similar (since amtterm doesn't have one, leaving it as-is is fine) Please request CVS branches following http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure and close this bug as RAWHIDE when it's been imported. Oops .. fatfingered status New Package CVS Request ======================= Package Name: amtterm Short Description: Serial-over-lan (sol) client for Intel AMT. Owners: kraxel Branches: F-7 EL-5 Cvsextras Commits: yes package committed to cvs and built. |