Bug 252101
Summary: | Review Request: joesnmp - Java SNMP class library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Vivek Lakshmanan <viveklak> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | low | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | cse.cem+redhatbugz, fedora-package-review, notting |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | http://sourceforge.net/projects/joesnmp/ | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-06-26 01:07:39 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Vivek Lakshmanan
2007-08-13 22:11:21 UTC
1) rpmlint -i says: joesnmp.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 53) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. 2) License should be LGPLv2+ (not just LGPL) as per the source and LICENSE.txt. 3) LICENSE.txt is shipped with the source zip, but doesn't contain the full LGPL, I am not sure whether or not it should be included in %doc. I think you are OK here. 4) Source0 should be a URL of the package on sf.net. (Did you mean http://downloads.sourceforge.net/joesnmp/joesnmp-0.3.4.zip ?) Closing as detailed in bug 252049 after a complete lack of response. |