Bug 2521257

[fedora-review-service-build]

Some pre-review comments:

1- Please remove the version minimums on build requirements, not needed (And will become even more useless as time goes)
2- I assume the requires are qml requirements? If so, please use the qt6qml() requirements
3- %cmake_kf6 should be under the %conf section, before %build (Yes, that is new)
4- For the patches, can you give some information in comments as to what they are? Are they upstreamed patches? If so, please show a link to the MR(s). If not, please note a purpose for the patches.

Taking this.

Fixes appstream-util validation failure caused by an invalid <icon type="stock"> entry in the metainfo.xml stock icons must name a generic freedesktop icon, not the app's own id. The icon is already resolved via the desktop-id launchable plus the installed hicolor svg, so the entry is simply wrong and deleted it.

Patch0: komodo-1.6.0-fix-appstream-metadata.patch

Adds SOVERSION to the internal QML backing libraries (libkomodo_models.so, libkomodo_ui.so). Upstream's CMake installs them unversioned directly into the public libdir even though they are linked by the komodo binary, which does not qualify for Fedora's unversioned-DSO exception.

Patch1: komodo-1.6.0-versioned-soname.patch

I fixed the rest of it.

Package adheers to the Fedora packaging rules
Package licenses are allowed into Fedora
Package installs and runs perfectly

PACKAGE APPROVED

Side notes to the packager, to be done upon import (This is not a blocker for this review):

1- Please do add a link to the MR for metainfo.xml patch in your spec, so it's easier to find when the app updates and the patch no longer applies
2- Do feel free to simply the %license lines in the %files to simply have LICENSES/* as you originally did (enumerating the licenses isn't necessary)
3- Please do consider adding the kde-sig group to the package once it's created

Fedora-review output:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Creative Commons CC0 1.0", "BSD
     2-Clause License", "Creative Commons Attribution-ShareAlike 4.0", "*No
     copyright* BSD 2-Clause License", "*No copyright* Creative Commons CC0
     1.0", "GNU General Public License, Version 2", "GNU Library General
     Public License, Version 2.0". 27 files have unknown license. Detailed
     output of licensecheck in
     /home/farchord/Documents/fedora/komodo/2521257-komodo/licensecheck.txt
[ ]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/qlogging-
     categories6, /usr/share/doc/HTML/en, /usr/share/doc/HTML
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 11661 bytes in 3 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: komodo-1.6.0-1.fc46.x86_64.rpm
          komodo-1.6.0-1.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmprcsj8ft4')]
checks: 32, packages: 2

komodo.src: E: spelling-error ('Todo', 'Summary(en_US) Todo -> Tod, Toto, Todd')
komodo.src: E: spelling-error ('todo', 'Summary(en_US) todo -> too, dodo, to do')
komodo.src: E: spelling-error ('txt', 'Summary(en_US) txt -> text, ext, tit')
komodo.src: E: spelling-error ('todo', '%description -l en_US todo -> too, dodo, to do')
komodo.src: E: spelling-error ('txt', '%description -l en_US txt -> text, ext, tit')
komodo.x86_64: E: spelling-error ('Todo', 'Summary(en_US) Todo -> Tod, Toto, Todd')
komodo.x86_64: E: spelling-error ('todo', 'Summary(en_US) todo -> too, dodo, to do')
komodo.x86_64: E: spelling-error ('txt', 'Summary(en_US) txt -> text, ext, tit')
komodo.x86_64: E: spelling-error ('todo', '%description -l en_US todo -> too, dodo, to do')
komodo.x86_64: E: spelling-error ('txt', '%description -l en_US txt -> text, ext, tit')
komodo.x86_64: W: no-manual-page-for-binary komodo
komodo.x86_64: E: incorrect-fsf-address /usr/share/licenses/komodo/LGPL-2.0-or-later.txt
 2 packages and 0 specfiles checked; 11 errors, 1 warnings, 49 filtered, 11 badness; has taken 0.4 s 




Rpmlint (debuginfo)
-------------------
Checking: komodo-debuginfo-1.6.0-1.fc46.x86_64.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpon54r85k')]
checks: 32, packages: 1

 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 18 filtered, 0 badness; has taken 0.5 s 





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.10.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 2

komodo.x86_64: E: spelling-error ('Todo', 'Summary(en_US) Todo -> Tod, Toto, Todd')
komodo.x86_64: E: spelling-error ('todo', 'Summary(en_US) todo -> too, dodo, to do')
komodo.x86_64: E: spelling-error ('txt', 'Summary(en_US) txt -> text, ext, tit')
komodo.x86_64: E: spelling-error ('todo', '%description -l en_US todo -> too, dodo, to do')
komodo.x86_64: E: spelling-error ('txt', '%description -l en_US txt -> text, ext, tit')
komodo.x86_64: W: no-manual-page-for-binary komodo
komodo.x86_64: E: incorrect-fsf-address /usr/share/licenses/komodo/LGPL-2.0-or-later.txt
 2 packages and 0 specfiles checked; 6 errors, 1 warnings, 68 filtered, 6 badness; has taken 2.1 s 



Unversioned so-files
--------------------
komodo: /usr/lib64/qt6/qml/org/kde/komodo/models/libkomodo_modelsplugin.so
komodo: /usr/lib64/qt6/qml/org/kde/komodo/ui/libkomodo_uiplugin.so

Source checksums
----------------
https://download.kde.org/stable/komodo/1.6.0/komodo-1.6.0.tar.xz :
  CHECKSUM(SHA256) this package     : c7a6321f0faadcf230df361beaac2e8b2e161b1d47d170b2036617581909089a
  CHECKSUM(SHA256) upstream package : c7a6321f0faadcf230df361beaac2e8b2e161b1d47d170b2036617581909089a


Requires
--------
komodo (rpmlib, GLIBC filtered):
    hicolor-icon-theme
    libKF6ColorScheme.so.6()(64bit)
    libKF6ConfigCore.so.6()(64bit)
    libKF6ConfigGui.so.6()(64bit)
    libKF6CoreAddons.so.6()(64bit)
    libKF6DBusAddons.so.6()(64bit)
    libKF6GuiAddons.so.6()(64bit)
    libKF6I18n.so.6()(64bit)
    libKF6I18nQml.so.6()(64bit)
    libKF6IconThemes.so.6()(64bit)
    libQt6Core.so.6()(64bit)
    libQt6Core.so.6(Qt_6)(64bit)
    libQt6Core.so.6(Qt_6.11)(64bit)
    libQt6Gui.so.6()(64bit)
    libQt6Gui.so.6(Qt_6)(64bit)
    libQt6Qml.so.6()(64bit)
    libQt6Qml.so.6(Qt_6)(64bit)
    libQt6Qml.so.6(Qt_6.11_PRIVATE_API)(64bit)
    libQt6QuickControls2.so.6()(64bit)
    libQt6QuickControls2.so.6(Qt_6)(64bit)
    libQt6Widgets.so.6()(64bit)
    libQt6Widgets.so.6(Qt_6)(64bit)
    libc.so.6()(64bit)
    libkomodo_models.so.0()(64bit)
    libkomodo_ui.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    qt6qml(org.kde.kirigami)
    qt6qml(org.kde.kirigamiaddons.dateandtime)
    qt6qml(org.kde.kirigamiaddons.formcard)
    qt6qml(org.kde.kitemmodels)
    rtld(GNU_HASH)



Provides
--------
komodo:
    application()
    application(org.kde.komodo.desktop)
    komodo
    komodo(x86-64)
    libkomodo_models.so.0()(64bit)
    libkomodo_modelsplugin.so()(64bit)
    libkomodo_ui.so.0()(64bit)
    libkomodo_uiplugin.so()(64bit)
    metainfo()
    metainfo(org.kde.komodo.metainfo.xml)
    qt6qml(org.kde.komodo.models)
    qt6qml(org.kde.komodo.ui)



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2521257
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Perl, PHP, fonts, SugarActivity, Python, Haskell, Ocaml, R, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

The Pagure repository was created at https://src.fedoraproject.org/rpms/komodo
Monitoring:
Anitya project is accessible by this link 
`https://release-monitoring.org/project/379835`
 you can modify it manually.
Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.

FEDORA-2026-c6faa29741 (komodo-1.6.0-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-c6faa29741

FEDORA-2026-c6faa29741 (komodo-1.6.0-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.