Bug 2522336

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10898228
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2522336-python-griffelib/fedora-rawhide-x86_64/10898228-python-griffelib/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I'll review it

Unblocking FE-NEEDSPONSOR - I just sponsored @chihlee.

Two issues - one serious another mostly cosmetic.

1. File `src/griffe/_internal/c3linear.py` is derived from MIT-licensed project so I believe `License` field should be adjusted.  I don't believe that MIT can be relicensed under ISC however both are compatible. 
2. Description is too long (cosmetic).

I don't see any serious issues so here is my formal

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: License field in the package spec file must matche the actual license.
     See my note above.
[x]: License file installed when any subpackage combination is installed.
[x]: Package owns all directories that it creates.
[x]: Package contains no bundled libraries or specifies bundled libraries
     with Provides: bundled(<libname>) if unbundling is not possible.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package does not contains desktop file (not a GUI application).
[-]: No separate development files
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: The package is not a rename of another package.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package does not contain systemd file(s).
[x]: Package is not known to require an ExcludeArch tag.
[-]: No large documentation files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: I did not test if the package functions as described.
[x]: Latest version is packaged (2.2.0).
[x]: Package does not include license text files separate from upstream.
[-]: No extra patches.
[-]: Sources weren't verified with gpgverify first in - upstream does not
     publish signatures.
[?]: I did not esat if the package compiles and builds into binary rpms
     on all supported architectures. Noarch package anyway.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-griffelib-2.2.0-1.fc46.noarch.rpm
          python3-griffelib+pypi-2.2.0-1.fc46.noarch.rpm
          python-griffelib-2.2.0-1.fc46.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.8.0
configuration:
    /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmp0rtkavvh')]
checks: 32, packages: 3

python-griffelib.src: E: description-line-too-long Griffe is a Python library that extracts the structure, frame, and skeleton of Python projects. It parses source code to compute signatures for entire Python programs, which can be used to generate API documentation or detect breaking changes in an API.
python3-griffelib.noarch: E: description-line-too-long Griffe is a Python library that extracts the structure, frame, and skeleton of Python projects. It parses source code to compute signatures for entire Python programs, which can be used to generate API documentation or detect breaking changes in an API.
 3 packages and 0 specfiles checked; 2 errors, 0 warnings, 16 filtered, 2 badness; has taken 1.0 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.10.0
configuration:
    /usr/lib/python3.15/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 33, packages: 2

python3-griffelib.noarch: E: description-line-too-long Griffe is a Python library that extracts the structure, frame, and skeleton of Python projects. It parses source code to compute signatures for entire Python programs, which can be used to generate API documentation or detect breaking changes in an API.
 2 packages and 0 specfiles checked; 1 errors, 0 warnings, 12 filtered, 1 badness; has taken 0.2 s 

^^^ See my note above.

Source checksums
----------------
https://files.pythonhosted.org/packages/source/g/griffelib/griffelib-2.2.0.tar.gz :
  CHECKSUM(SHA256) this package     : e1bc36fe9cd21d4b6b659b456346755e4cfdc5676c0a5214083126ee12612b3c
  CHECKSUM(SHA256) upstream package : e1bc36fe9cd21d4b6b659b456346755e4cfdc5676c0a5214083126ee12612b3c


Requires
--------
python3-griffelib (rpmlib, GLIBC filtered):
    python(abi)

python3-griffelib+pypi (rpmlib, GLIBC filtered):
    python(abi)
    python3-griffelib
    python3.15dist(pip)
    python3.15dist(platformdirs)
    python3.15dist(wheel)



Provides
--------
python3-griffelib:
    python-griffelib
    python3-griffelib
    python3.15-griffelib
    python3.15dist(griffelib)
    python3dist(griffelib)

python3-griffelib+pypi:
    python-griffelib+pypi
    python3-griffelib+pypi
    python3.15-griffelib+pypi
    python3.15dist(griffelib[pypi])
    python3dist(griffelib[pypi])



Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29
Command line :/usr/bin/fedora-review -b 2522336
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: PHP, SugarActivity, R, Perl, Haskell, fonts, Ocaml, C/C++, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH


Please address two issues and considering it's done this package is

================
=== APPROVED ===
================

The Pagure repository was created at https://src.fedoraproject.org/rpms/python-griffelib
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

FEDORA-2026-6066546d62 (python-griffelib-2.2.0-2.fc46) has been submitted as an update to Fedora 46.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-6066546d62

FEDORA-2026-6066546d62 (python-griffelib-2.2.0-2.fc46) has been pushed to the Fedora 46 stable repository.
If problem still persists, please make note of it in this bug report.